Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition away from ocd-ids instruction source #599

Closed
chrismytton opened this issue Apr 10, 2017 · 1 comment
Closed

Transition away from ocd-ids instruction source #599

chrismytton opened this issue Apr 10, 2017 · 1 comment
Assignees

Comments

@chrismytton
Copy link
Contributor

Problem

Fuzzy matching OCD areas in the build process is causing problems with Uganda, see everypolitician/everypolitician-data#31158 (comment) for more details. The code for handling OCD ids has never been terribly satisfying and seems to be a constant source of issues.

Proposed Solution

Remove the ocd-ids instruction type. Currently it's only Australia/Representatives and Uganda/Parliament that are using this, so perhaps it would be better to make the OCD ids a manually generated CSV for those countries.

We want to try and transition to using MapIt and Wikidata as our primary sources of area information, rather than using OCD IDs directly. Migrating these two legislatures over to one or both of Mapit/Wikidata seems like a better use of our time than fixing the OCD fuzzy matching problems.

Acceptance Criteria

Australia/Representatives and Uganda/Parliament should no longer have an ocd-ids instruction type and should be getting their area information from Mapit and/or Wikidata.

Not Required

We don't need to change anything in other legislatures that include OCD IDs from the scraper, these are fine as they are since the ID is just used as a plain text identifier string. This change is just about changing the two places that try to do matching between area names and OCD IDs.

Related Issues

@tmtmtmtm
Copy link
Contributor

The areas for Australia/Representatives are now mapped to Wikidata (since everypolitician/everypolitician-data#51981). They're still keyed (and reconciled) on OCD ids, but it will now be easier to switch entirely to Wikidata IDs.

tmtmtmtm added a commit to everypolitician/everypolitician-data that referenced this issue Jun 7, 2018
tmtmtmtm added a commit to everypolitician/everypolitician-data that referenced this issue Jun 7, 2018
@ghost ghost assigned tmtmtmtm Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants