You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fuzzy matching OCD areas in the build process is causing problems with Uganda, see everypolitician/everypolitician-data#31158 (comment) for more details. The code for handling OCD ids has never been terribly satisfying and seems to be a constant source of issues.
Proposed Solution
Remove the ocd-ids instruction type. Currently it's only Australia/Representatives and Uganda/Parliament that are using this, so perhaps it would be better to make the OCD ids a manually generated CSV for those countries.
We want to try and transition to using MapIt and Wikidata as our primary sources of area information, rather than using OCD IDs directly. Migrating these two legislatures over to one or both of Mapit/Wikidata seems like a better use of our time than fixing the OCD fuzzy matching problems.
Acceptance Criteria
Australia/Representatives and Uganda/Parliament should no longer have an ocd-ids instruction type and should be getting their area information from Mapit and/or Wikidata.
Not Required
We don't need to change anything in other legislatures that include OCD IDs from the scraper, these are fine as they are since the ID is just used as a plain text identifier string. This change is just about changing the two places that try to do matching between area names and OCD IDs.
The areas for Australia/Representatives are now mapped to Wikidata (since everypolitician/everypolitician-data#51981). They're still keyed (and reconciled) on OCD ids, but it will now be easier to switch entirely to Wikidata IDs.
Problem
Fuzzy matching OCD areas in the build process is causing problems with Uganda, see everypolitician/everypolitician-data#31158 (comment) for more details. The code for handling OCD ids has never been terribly satisfying and seems to be a constant source of issues.
Proposed Solution
Remove the
ocd-ids
instruction type. Currently it's onlyAustralia/Representatives
andUganda/Parliament
that are using this, so perhaps it would be better to make the OCD ids a manually generated CSV for those countries.We want to try and transition to using MapIt and Wikidata as our primary sources of area information, rather than using OCD IDs directly. Migrating these two legislatures over to one or both of Mapit/Wikidata seems like a better use of our time than fixing the OCD fuzzy matching problems.
Acceptance Criteria
Australia/Representatives
andUganda/Parliament
should no longer have anocd-ids
instruction type and should be getting their area information from Mapit and/or Wikidata.Not Required
We don't need to change anything in other legislatures that include OCD IDs from the scraper, these are fine as they are since the ID is just used as a plain text identifier string. This change is just about changing the two places that try to do matching between area names and OCD IDs.
Related Issues
The text was updated successfully, but these errors were encountered: