Uganda (Parliament): Stop fuzzy matching OCD areas #12496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Summary of changes in PeopleAddedNo people added RemovedNo people removed Name ChangesNo name changes Wikidata ChangesNo changes OrganizationsAddedNo organizations added RemovedNo organizations removed |
37 tasks
This was matching several areas incorrectly, so rather than have incorrect data we're going to only do an exact match and then get an updated mapping file that includes the corrections.
chrismytton
force-pushed
the
uganda-stop-fuzzy-matching-areas
branch
from
b1ec967 to
2ee1cd0
Compare
|
Summary of changes in PeopleAddedNo people added RemovedNo people removed Name ChangesNo name changes Additional Name ChangesNo name changes Wikidata ChangesNo changes OrganizationsAddedNo organizations added RemovedNo organizations removed TermsAddedNo terms added RemovedNo terms removed ElectionsAddedNo elections added RemovedNo elections removed |
This ensures that anywhere that has an OCD id in the area_id column gets mapped to the correct area name based on the OCD CSV.
chrismytton
force-pushed
the
uganda-stop-fuzzy-matching-areas
branch
from
b176e01 to
3877ac9
Compare
chrismytton
force-pushed
the
uganda-stop-fuzzy-matching-areas
branch
from
3877ac9 to
14a971d
Compare
30 tasks
|
This Pull Request has been superseded by #12496 but there are non-bot commits. @chrismytton is this pull request still needed? |
|
Closing as this code has drifted from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing some bad data, e.g.:
So instead of doing a fuzzy match we're now doing an exact match. This means we'll need to get an updated mapping file from Collin which maps to the correct area names.