Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blr/chores/upgrade/react/v16.3.2 #58

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Blr/chores/upgrade/react/v16.3.2 #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5cf05b
Upgrade React to v16.3.2
bartriordan May 4, 2018
c678f50
Update some dependencies and add PhantomJS shim
bartriordan May 4, 2018
9fc5d78
Merge branch 'dev' into blr/chores/upgrade/react/v16.3.2
bartriordan Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ module.exports = function(config) {
webpack: webpackConfig,
frameworks: ['es5-shim', 'mocha', 'chai', 'sinon-chai', 'chai-jquery', 'jquery-3.3.1'],
files: [
'./node_modules/es6-shim/es6-shim.js',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why PhantomJS is busted in this repo without the ES6 shim, but this approach is recommended by others for fixing this exact issue with Karma.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think phantom actually just doesn't support certain parts of es6...

'./test/index.js'
],
preprocessors: {
Expand Down
18 changes: 11 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,27 +42,31 @@
"babel-preset-react": "^6.24.1",
"babel-preset-stage-3": "^6.24.1",
"chai": "^3.2.0",
"es6-shim": "^0.35.3",
"eslint": "^4.8.0",
"eslint-plugin-babel": "^4.0.1",
"eslint-plugin-react": "^7.10.0",
"flux": "^3.1.3",
"invariant": "^2.1.0",
"jquery": "^3.0.0",
"karma": "^2.0.5",
"karma-chai-plugins": "^0.6.0",
"karma-chrome-launcher": "^0.2.0",
"karma-chai-plugins": "^0.9.0",
"karma-chrome-launcher": "^2.2.0",
"karma-es5-shim": "0.0.4",
"karma-jquery": "^0.2.3",
"karma-mocha": "^0.2.0",
"karma-mocha": "^1.3.0",
"karma-phantomjs-launcher": "^1.0.4",
"karma-sourcemap-loader": "^0.3.7",
"karma-webpack": "^4.0.0-beta.0",
"karma-phantomjs-launcher": "^1.0.4",
"karma-sourcemap-loader": "^0.3.5",
"karma-webpack": "^3.0.0",
"karma-webpack": "^4.0.0-beta.0",
"keymirror": "^0.1.1",
"mocha": "^2.2.5",
"mocha": "^5.1.1",
"object-assign": "^3.0.0",
"prop-types": "^15.5.8",
"react": "^15.6.2",
"react-dom": "^15.6.2",
"react": "^16.3.2",
"react-dom": "^16.3.2",
"rimraf": "^2.5.2",
"sinon": "^1.15.4",
"webpack": "^4.16.3"
Expand Down
2 changes: 1 addition & 1 deletion test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ import FUHelpers from '../src/testUtils/ChaiAddons'

chai.use(FUHelpers)

const libContext = require.context('./lib/', true, /Spec.js$/)
const libContext = require.context('./lib/', true, /Spec\.js$/)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BS: we had never escaped the period in the regex for some reason.

libContext.keys().forEach(libContext)
Loading