Blr/chores/upgrade/react/v16.3.2 #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartriordan
commented
May 4, 2018
| @@ -8,6 +8,7 @@ module.exports = function(config) { | |||
| webpack: webpackConfig, | |||
| frameworks: ['es5-shim', 'mocha', 'chai', 'sinon-chai', 'chai-jquery', 'jquery-2.1.0'], | |||
| files: [ | |||
| './node_modules/es6-shim/es6-shim.js', | |||
There was a problem hiding this comment.
Not sure why PhantomJS is busted in this repo without the ES6 shim, but this approach is recommended by others for fixing this exact issue with Karma.
There was a problem hiding this comment.
I think phantom actually just doesn't support certain parts of es6...
bartriordan
commented
May 4, 2018
package.json
Outdated
| "eslint": "^4.8.0", | ||
| "eslint-plugin-babel": "^4.0.1", | ||
| "eslint-plugin-react": "^7.3.0", | ||
| "flux": "^3.1.3", | ||
| "invariant": "^2.1.0", | ||
| "jquery": "^3.0.0", | ||
| "karma": "^0.12.31", | ||
| "karma": "^2.0.2", |
There was a problem hiding this comment.
Did some other upgrades to keep things moving
| @@ -2,5 +2,5 @@ import FUHelpers from '../src/testUtils/ChaiAddons' | |||
|
|
|||
| chai.use(FUHelpers) | |||
|
|
|||
| const libContext = require.context('./lib/', true, /Spec.js$/) | |||
| const libContext = require.context('./lib/', true, /Spec\.js$/) | |||
There was a problem hiding this comment.
BS: we had never escaped the period in the regex for some reason.
|
👍 LGTM |
maneeshanand
reviewed
Apr 5, 2019
|
@BJK you're blocking our React 16 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BJK @maneeshanand @andela-tkomolafe @whabib Please review. This PR preps for upgrading web-apps to React v16 by bumping some dependencies and adding a shim that fixes an issue with the tests in PhantomJS.