Fix webpack support #159
Merged
Fix webpack support #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you! |
|
Hmm, seems like the tests are failing, any idea why? |
|
Unsure. Will try to look later tonight.
Re: the test versions, seems like 0.10 and 0.12 can be cut out and 4.x,
6.x, and latest should be the only things tested, no?
…On Mon, Nov 28, 2016 at 4:07 AM Linus Unnebäck ***@***.***> wrote:
Hmm, seems like the tests are failing, any idea why?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#159 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAL_Jv-Jp4l-ye4aX3gqbp-eIrGlXCeCks5rCqfogaJpZM4K9Tk4>
.
|
|
I don't think we should drop 0.10 or 0.12 support without cutting a major release... |
|
To be fair this is 0.x series so technically can do whatever you want, but
I get you. A 1.x would be nice :)
…On Mon, Nov 28, 2016 at 3:45 PM John-David Dalton ***@***.***> wrote:
Major bump 🎉
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#159 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAL_JnIY44LiTxg66tjCgugOlKMFV08iks5rC0uSgaJpZM4K9Tk4>
.
|
|
@LinusU as always, sorry for the delay. Two issues with the tests:
Both are fixed with the latest version of the PR. I have not changed anything WRT version, etc. |
LinusU
reviewed
Dec 28, 2016
| if (!contents && fs.existsSync(source)) { | ||
| contents = fs.readFileSync(source, 'utf8'); | ||
| try { | ||
| const fs = require('fs'); |
There was a problem hiding this comment.
This should probably be var to not upset any old browsers? Maybe we can move the try/catch to the top of the file even 🤔
var fs
try {
fs = require('fs')
} catch (_) {
// Loading in catch block to convert webpack error to warning.
} if (!contents && fs && fs.existsSync(source)) {
contents = fs.readFileSync(source, 'utf8');
|
This is amazing 😍 only one small nit, then it's good to go! |
|
@LinusU done. |
|
Thank you! |
|
Released as 0.4.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts the webpack errors to warnings. Individual users may use the ignore plugin to further mute these warnings.