-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught TypeError in latest Chrome while accessing error.stack #167
Comments
I have the same issue. It looks like this is due to "fs". Looks like 'fs' is defined but not existsSync, I guess the bug is introduced by b19ff76#diff-f332e9a051ea7f7b602a3d633c506d30R77 If you run I'll try to see what I can do to fix it. |
Thanks for the quick fix and 0..4.10 release. The bug is gone for me. |
Yes thanks! I confirm it's working for me as well. |
🎉 🎉 |
Fixes evanw/node-source-map-support#167 Since version 0.4.9, we require `fs` but it should fail if we are in a browser. However, `browser-source-map-support.js` is bundled with browserify which converts unsupported builtins to empty object. See https://github.com/substack/node-browserify/blob/8f5ebbf505/lib/builtins.js#L12 This PR checks if required `fs` contains `readFileSync` which is part of `fs` API.
This was working very well until version 0.4.8.
After upgrading to version 0.4.9, I get in the console:
The code in pipelet.js triggering this is:
The text was updated successfully, but these errors were encountered: