Amendments to y2038 #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or messages if the files are not found.
…he C99 standard says. Two leap seconds in the same minute are not allowed (the C90 range 0..61 was a defect).
…ndard int64_t instead.
…es not actually guarantee that the 'true' value of a boolean expression is exactly 1.
…er name like WRAP_TIME64.
|
I haven't forgotten about this. I'm off learning a bunch of C so I can do a better job fixing up this project. LMK if there's urgency on getting this integrated. |
|
It has been a few months now. Any chance of getting at least some of the issues mentioned in the pull request fixed? |
|
Looks like this was all covered in #14, so I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo Schwern:
I have made all changes as discussed plus a few more. Points left are:
mktime64(140728004163928)
have: 12344592500
want: 12344678900
t/mktime64.t ............... Failed 1/17 subtests
Could you please take a look at it?
I am a bit worried that the code in timegm64() that calculates dates
is not in sync with the code currently in Perl's source code.
There are other places like safe_year() that have more validation in your version than in Perl.
You are one of the Perl gurus, aren't you? Could you try to get those changes merged into Perl?
The Perl's source codes uses floating point, which seems a waste of time, search for Perl_fmod().
Thanks,
rdiez