mktime64 test fixes, and optimizations #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or messages if the files are not found.
…he C99 standard says. Two leap seconds in the same minute are not allowed (the C90 range 0..61 was a defect).
…ndard int64_t instead.
…es not actually guarantee that the 'true' value of a boolean expression is exactly 1.
…er name like WRAP_TIME64.
preprocessed with -E
use the right format printf specifier, long long or just long fix t/asctime64.t.c, use the result of asctime_r_ret2 add -DHAS_TM_TM_GMTOFF -DHAS_TM_TM_ZONE to linux, using _DEFAULT_SOURCE tap: cast year to year_t (int or long) time64.h: dont want to include inttypes.h, so hack our own PRId64 define
use an hour which does not overflow to the next or prev day. test all kind of years, esp. leap years with out of bound dates. add simplier IS_LEAP_ABS test for absolute years, only > 0. optimize seconds_between_years adjustment.
on older glibc -DHAS_TM_TM_GMTOFF -DHAS_TM_TM_ZONE is wrong
|
+1 on merge. |
schwern
reviewed
Apr 19, 2017
t/mktime64.t.c
Outdated
| @@ -50,6 +49,12 @@ int main(void) { | |||
| date.tm_mday = 37; | |||
| date.tm_wday = 9; /* deliberately wrong week day */ | |||
| date.tm_yday = 487; /* and wrong year day */ | |||
| #ifdef HAS_TM_TM_GMTOFF | |||
| /*date.tm_gmtoff = 0;*/ | |||
There was a problem hiding this comment.
Should this be uncommented?
schwern
reviewed
Apr 19, 2017
t/tap.h
Outdated
| @@ -1,6 +1,12 @@ | |||
| #include <stdarg.h> | |||
| #include "time64.h" | |||
|
|
|||
| #ifdef USE_TM64 | |||
There was a problem hiding this comment.
Maybe we need to define a year_t in the library itself.
schwern
reviewed
Apr 19, 2017
| @@ -87,8 +86,7 @@ int is_str(const char* have, const char* want, const char *message, ...) { | |||
| do_test( test, message, args ); | |||
|
|
|||
| if( !test ) { | |||
| diag("have: %s", have); | |||
| diag("want: %s", want); | |||
| diag("have: %s, want: %s", have, want); | |||
There was a problem hiding this comment.
have and want are supposed to be on two lines, the two values are lined up to more easily see the difference.
schwern
reviewed
Apr 19, 2017
t/tap.c
Outdated
| @@ -106,8 +104,7 @@ int is_Int64(const Int64 have, const Int64 want, const char *name, ...) { | |||
| do_test( test, name, args ); | |||
|
|
|||
| if( !test ) { | |||
| diag("have: %"PRId64, have); | |||
| diag("want: %"PRId64, want); | |||
| diag("have: %"PRId64" want: %"PRId64" diff: %"PRId64, have, want, have-want); | |||
schwern
reviewed
Apr 19, 2017
Makefile
Outdated
| @@ -20,7 +20,8 @@ ifeq ($(UNAME_S),Linux) | |||
| # (instead of __tm_gmtoff and __tm_zone) in struct tm, | |||
| # and _POSIX_SOURCE (there are alternatives) for tzset(). | |||
| # _BSD_SOURCE is deprecated, use _DEFAULT_SOURCE instead | |||
| CFLAGS += -D_DEFAULT_SOURCE -D_POSIX_SOURCE -DHAS_TM_TM_GMTOFF -DHAS_TM_TM_ZONE | |||
| CFLAGS += -D_BSD_SOURCE -D_DEFAULT_SOURCE -D_POSIX_SOURCE | |||
| #CFLAGS += -D_DEFAULT_SOURCE -D_POSIX_SOURCE -DHAS_TM_TM_GMTOFF -DHAS_TM_TM_ZONE | |||
There was a problem hiding this comment.
Reminding myself to remove this commented out line.
|
Thanks a lot for doing all that work! Sorry it took so long to review and merge. |
It's the naming convention for cc -E preprocessed .c files. You inspect macro expansions and included headers. |
|
Welcome back! We missed you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge and fix rdiez' improvements.
improve the Makefile, detect Linux and Darwin, and add the needed HAS_TM defines.
support make DEBUG=1 and USE_TM64=1
add tap.h declarations
replace %lld printf with %PRId64 from inttypes.h
Fix fragile t/mktime64.t
use an hour which does not overflow to the next or prev day.
test all kind of years, esp. leap years with out of bound dates
various minor optimizations