v2.0.1 #15
Open
v2.0.1 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redconfetti
commented
Nov 18, 2023
redconfetti
commented
- Pulls in changes from dlindahl@4ab8a1c9c3333 and Update for OmniAuth v2 dlindahl/omniauth-cas#68
- Updates Ruby version and gem dependencies
- Updates OmniAuth::Strategies::CAS::SamlTicketValidator to match new contract for v2.0.0 validators
- Applies spec/testing to OmniAuth::Strategies::CAS::SamlTicketValidator
redconfetti
force-pushed
the
ets-update-v2.0.1
branch
from
65e67ee
to
ebaf568
Compare
(Travis doesn't have Ruby 2.3 yet)
- Drop unsupported Rubies - Add Ruby 2.3.1 (Travis/RVM needs an exact version for 2.3 for some reason)
Forwards the XML response received from CASAuth to the fetch_raw_info callback, which now accepts five arguments (cas, options, ticket, user info, and the raw response). Developers who override fetch_raw_info with a Proc are unaffected -- the new argument is silently discarded -- but developers who use a Lambda will need to update their code.
Requires updating webmock; see: bblimke/webmock#683
Also uses https where possible
Response body in Rack 2 is returned as an array instead of a `Rack::BodyProxy` object. This change allows specs to succeed with both Rack 1.x and 2.x versions.
Also improves Travis CI configuration by specifying `dist`, `os`, and `language` parameters
…e and asserting attributes
OmniAuth v2 converts all GET requests to POST requests by default with CSRF protection. Closes dlindahl#62
…ator. Adds #success_body loading in OmniAuth::Strategies::CAS::SamlTicketValidator
redconfetti
force-pushed
the
ets-update-v2.0.1
branch
from
ebaf568
to
162bef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.