Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for OmniAuth v2 #68

Closed
wants to merge 1 commit into from
Closed

Update for OmniAuth v2 #68

wants to merge 1 commit into from

Conversation

stanhu
Copy link

@stanhu stanhu commented Jun 19, 2022

OmniAuth v2 converts all GET requests to POST requests by default
with CSRF protection.

Closes #62

@stanhu stanhu mentioned this pull request Jun 19, 2022
Closed
4 tasks
@stanhu
Update for OmniAuth v2
4211e6d 
OmniAuth v2 converts all GET requests to POST requests by default
with CSRF protection.

Closes dlindahl#62
@jcmfernandes
Copy link

jcmfernandes commented Nov 7, 2022 •
edited
Loading

Hey @dlindahl mind reviewing and merging this, and then releasing it with a major version bump? mastodon uses this gem and it's stuck on OmniAuth v1 because of it. Thank you so much! 🙌

@armandfardeau
Copy link

Hi, wanted to know where you are on this. We use your gem (thank you by the way) in some of our projects and need to update soon.

@casaper casaper mentioned this pull request Jan 21, 2023
Closed
@ZephOne
Copy link

ZephOne commented Feb 7, 2023 •
edited
Loading

Hi, do you have any news about merging this pull request ?
Do not hesitate if you need help.

@tagliala
Copy link
Collaborator

tagliala commented Feb 7, 2023

Hi, as the opener of #62, I was working on this feature

I have no permissions to merge PRs here, but I have indeed a branch (based on an outdated version of this gem, sorry)

I think that this two commits should be part of this feature, since they will keep testing against OmniAuth 1:
23b124d
1744cbb

@vjt
Copy link
Collaborator

vjt commented Feb 7, 2023

I can merge PRs here as @dlindahl had once granted me access - @dlindahl as @tagliala is still actively working on this gem, may you grant rights to him as well?

In the meantime I can merge this if instructed to do so (sorry I am too much out of context at this point :-)

Thank you!

@mjankowski mjankowski mentioned this pull request Mar 21, 2023
Merged
@mjankowski
Copy link

Would love to see this merged -- we're currently pointing at the PR branch in a larger omniauth update PR, and would prefer to point at an official release of omniauth-cas, or at least a non-PR branch if possible. Thanks everyone for the work here!

This was referenced Sep 19, 2023
Closed
Merged
This was referenced Nov 18, 2023
Closed
Open
@FedeJure
Copy link

Hi, Why this is not merged yet??? I would like to see this mr merged too.

@tagliala
Copy link
Collaborator

Superseded by #82, thanks!

@tagliala tagliala closed this Jan 10, 2024
@tagliala
Copy link
Collaborator

Hello, is someone using the v3 beta? Can we release v3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OmniAuth 2 compatibility
8 participants
@stanhu @jcmfernandes @armandfardeau @ZephOne @tagliala @vjt @mjankowski @FedeJure