Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed login keyboard dismiss error on login click #543

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fixed login keyboard dismiss error on login click #543

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef64c00
Fixed login keyboard dismiss error on login click
shubham-eaton Nov 11, 2024
c0f9fd2
Added keyboard dismiss function on login and rememberMe click
shubham-eaton Nov 11, 2024
3df79f4
Package updated to alpha
shubham-eaton Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions login-workflow/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v7.0.1 (November 11, 2024)

### Fixed

- Pressing login does not dismiss keyboard and can obscure error modal [514](https://github.com/etn-ccis/blui-react-native-workflows/issues/514)

## v7.0.0 (September 20, 2024)

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion login-workflow/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@brightlayer-ui/react-native-auth-workflow",
"description": "Re-usable workflow components for Authentication and Registration within Eaton applications.",
"version": "7.0.0",
"version": "7.0.1",
"license": "BSD-3-Clause",
"author": {
"name": "Brightlayer UI",
Expand Down
4 changes: 3 additions & 1 deletion login-workflow/src/screens/LoginScreen/LoginScreenBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { LoginScreenProps } from './types';
import { WorkflowCard } from '../../components/WorkflowCard';
import { WorkflowCardBody } from '../../components/WorkflowCard/WorkflowCardBody';
import { ErrorManager, PasswordTextField } from '../../components';
import { Image, View, StyleSheet, ViewStyle } from 'react-native';
import { Image, View, StyleSheet, ViewStyle, Keyboard } from 'react-native';
import { Button, Checkbox, HelperText, Text, TextInput } from 'react-native-paper';
import { useExtendedTheme } from '@brightlayer-ui/react-native-themes';
import { useScreenDimensions } from '../../hooks/useScreenDimensions';
Expand Down Expand Up @@ -200,6 +200,7 @@ export const LoginScreenBase: React.FC<React.PropsWithChildren<LoginScreenProps>
};

const handleRememberMeChanged = (value: boolean): void => {
Keyboard.dismiss();
if (onRememberMeChanged) {
onRememberMeChanged(value);
setRememberMe(value);
Expand All @@ -213,6 +214,7 @@ export const LoginScreenBase: React.FC<React.PropsWithChildren<LoginScreenProps>
isPasswordValid;

const handleLogin = (): void => {
Keyboard.dismiss();
if (isFormValid() && onLogin) void onLogin(username, password, rememberMe);
};
const handleLoginSubmit = (): void => {
Expand Down
Loading