Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed login keyboard dismiss error on login click #543

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

shubham-eaton
Copy link
Contributor

@shubham-eaton shubham-eaton commented Nov 11, 2024

Fixes #514.

  • Fixed keyboard dismiss error on login screen

To test -->

  • Run yarn start:example-android
  • Open index.tsx under navigation folder and replace OktaLogin with Login

@github-actions github-actions bot added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.42%. Comparing base (665edbb) to head (3df79f4).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #543      +/-   ##
==========================================
+ Coverage   76.38%   76.42%   +0.03%     
==========================================
  Files          78       78              
  Lines        1245     1247       +2     
  Branches      247      247              
==========================================
+ Hits          951      953       +2     
  Misses        109      109              
  Partials      185      185              
Flag Coverage Δ
unittests 76.42% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeffGreiner-eaton
Copy link
Collaborator

JeffGreiner-eaton commented Nov 11, 2024

This looks good on both iOS and Android

  • if this fix is needed, I would update version to beta or alpha to publish updated package off dev branch. If not connect with adopter team
android-key-dismiss.mov
ios-key-dismiss.mov

@shubham-eaton shubham-eaton merged commit af7c2ac into dev Nov 12, 2024
8 checks passed
@shubham-eaton shubham-eaton deleted the bug/login-keyboard-dismiss branch November 12, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering
Development

Successfully merging this pull request may close these issues.

Pressing login does not dismiss keyboard and can obscure error modal
2 participants