-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement WorkflowCardBody Component #319
Implement WorkflowCardBody Component #319
Conversation
This looks good on Android phone, unable to verify the hook & styles for tablet if
Also we need to figure out if we want to continue to use react-test-renderer or just use { render } from '@testing-library/react-native' This would remove the setup stuff thats required from the renderer.
we also need to remove enzyme items from package |
@@ -0,0 +1,24 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe something like this..
/**
* @format
*/
import React from 'react';
import { cleanup, render, screen } from '@testing-library/react-native';
import { WorkflowCardBody } from 'src/components/WorkflowCard';
import { Text } from 'react-native-paper';
describe('WorkflowCardBody Test', () => {
afterEach(cleanup);
it('WorkflowCardBody renders correctly', () => {
render(
<WorkflowCardBody>
<Text>This is workflow card body content.</Text>
</WorkflowCardBody>
)
.toJSON();
expect(render).toBeTruthy();
expect(screen.getByText('This is workflow card body content.')).toBeTruthy();
});
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works fine on ios.
Just the small changes @JeffGreiner-eaton suggested.
Fixes 5099 .
Changes proposed in this Pull Request:
- Update JsDocs
- Write test cases with 80% coverage
- Update the demo in an example project to showcase the component.
- Update Readme
- Test in Dark / Light Theme
- Test It in RTL view
- Styling as per https://brightlayer-ui.github.io/patterns/forms#mobile
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?