-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement WorkflowCardBody Component #313
Closed
ektaghag-eaton
wants to merge
11
commits into
release/R31
from
feature/blui-5099-implement-workflowCardBody
Closed
Implement WorkflowCardBody Component #313
ektaghag-eaton
wants to merge
11
commits into
release/R31
from
feature/blui-5099-implement-workflowCardBody
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ektaghag-eaton
requested review from
JeffGreiner-eaton,
surajeaton and
joebochill
as code owners
January 18, 2024 07:05
github-actions
bot
added
the
brightlayer-ui
Used to identify Brightlayer UI platform issues for easy filtering
label
Jan 18, 2024
surajeaton
reviewed
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this to new_architecture folder.
…native-workflows into feature/blui-5099-implement-workflowCardBody
…native-workflows into feature/blui-5099-implement-workflowCardBody
Opened new PR #319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 5099 .
Changes proposed in this Pull Request:
- Update JsDocs
- Write test cases with 80% coverage
- Update the demo in an example project to showcase the component.
- Update Readme
- Test in Dark / Light Theme
- Test It in RTL view
- Styling as per https://brightlayer-ui.github.io/patterns/forms#mobile
Screenshots / Screen Recording (if applicable)
To Test:
Any specific feedback you are looking for?