Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

ensure that db_index is never None on RedisSettings #1427

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Oct 14, 2022

Purpose

Update the RedisSettings model to set db_index to an empty string if it's None. I chose this method because it's essentially what the code is already doing while also catching the None edge case.

Changes

  • Add validation check for db_index

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1426

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review October 14, 2022 15:05
@seanpreston seanpreston merged commit 577cb6e into main Oct 17, 2022
@seanpreston seanpreston deleted the 1426_redix_config_bug branch October 17, 2022 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure config.redis.db_index is never None when building URL
2 participants