ensure that db_index is never None on RedisSettings (#1427)

* ensure db_index is never `None` * update changelog
ethyca · Oct 17, 2022 · 577cb6e · 577cb6e
1 parent da6fe5f
commit 577cb6e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,7 +17,8 @@ The types of changes are:
 * `Security` in case of vulnerabilities.
 
 ## [Unreleased](https://github.com/ethyca/fidesops/compare/1.8.1...main)
-
+### Changed
+* Fix redis `db_index` config issue [#1427](https://github.com/ethyca/fidesops/pull/1427)
 
 ## [1.8.0](https://github.com/ethyca/fidesops/compare/1.8.0...1.8.1)
 

diff --git a/src/fidesops/ops/core/config.py b/src/fidesops/ops/core/config.py
@@ -78,7 +78,8 @@ def assemble_connection_url(
             # If the whole URL is provided via the config, preference that
             return v
 
-        return f"redis://{quote_plus(values.get('user', ''))}:{quote_plus(values.get('password', ''))}@{values.get('host', '')}:{values.get('port', '')}/{values.get('db_index', '')}"
+        db_index = values.get("db_index") if values.get("db_index") is not None else ""
+        return f"redis://{quote_plus(values.get('user', ''))}:{quote_plus(values.get('password', ''))}@{values.get('host', '')}:{values.get('port', '')}/{db_index}"
 
     class Config:
         env_prefix = "FIDESOPS__REDIS__"