Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Pass in Vault environment variables if they are present locally #1275

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Pass in Vault environment variables if they are present locally #1275

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51359fd
Pass in Vault environment variables if they are present locally
galvana Sep 8, 2022
2eec5ba
Changelog and minor cleanup
galvana Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ services:
- FIDESOPS__LOG_PII=${FIDESOPS__LOG_PII}
- FIDESOPS__HOT_RELOAD=${FIDESOPS__HOT_RELOAD}
- FIDESOPS__ROOT_USER__ANALYTICS_ID=${FIDESOPS__ROOT_USER__ANALYTICS_ID}
- VAULT_ADDR=${VAULT_ADDR}
- VAULT_NAMESPACE=${VAULT_NAMESPACE}
- VAULT_TOKEN=${VAULT_TOKEN}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try testing locally with this change:

Suggested change
- VAULT_ADDR=${VAULT_ADDR}
- VAULT_NAMESPACE=${VAULT_NAMESPACE}
- VAULT_TOKEN=${VAULT_TOKEN}
- VAULT_ADDR
- VAULT_NAMESPACE
- VAULT_TOKEN

I don't believe the placeholder values should be necessary (for any of these ENV vars).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That worked 👍


db:
image: postgres:12
Expand Down