This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Pass in Vault environment variables if they are present locally #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSalant726
reviewed
Sep 8, 2022
docker-compose.yml
Outdated
Comment on lines
28
to
30
| - VAULT_ADDR=${VAULT_ADDR} | ||
| - VAULT_NAMESPACE=${VAULT_NAMESPACE} | ||
| - VAULT_TOKEN=${VAULT_TOKEN} |
There was a problem hiding this comment.
Can you try testing locally with this change:
Suggested change
| - VAULT_ADDR=${VAULT_ADDR} | |
| - VAULT_NAMESPACE=${VAULT_NAMESPACE} | |
| - VAULT_TOKEN=${VAULT_TOKEN} | |
| - VAULT_ADDR | |
| - VAULT_NAMESPACE | |
| - VAULT_TOKEN |
I don't believe the placeholder values should be necessary (for any of these ENV vars).
eastandwestwind
approved these changes
Sep 8, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Pass in Vault environment variables if they are present locally * Changelog and minor cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To reduce the amount of steps in setting up a developer's Vault integration for connector development
Changes
docker-compose.ymlso they don't need to be mapped manually after runningnox -s dev -- shellChecklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external services