Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove customField feature flag #3080

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Remove customField feature flag #3080

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a3c010
Remove `customField` feature flag
TheAndrewJackson Apr 17, 2023
66451fb
update changelog
TheAndrewJackson Apr 17, 2023
f6d9713
Update clients/admin-ui/src/features/common/custom-fields/hooks.ts
TheAndrewJackson Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ The types of changes are:

### Removed
- Removed the warning about access control migration [#3055](https://github.com/ethyca/fides/pull/3055)
- Remove `customFields` feature flag [#3080](https://github.com/ethyca/fides/pull/3080)

## [2.11.0](https://github.com/ethyca/fides/compare/2.10.0...2.11.0)

Expand Down
4 changes: 2 additions & 2 deletions clients/admin-ui/src/features/common/custom-fields/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ export const useCustomFields = ({
resourceType,
}: UseCustomFieldsOptions) => {
const { errorAlert, successAlert } = useAlert();
const { flags, plus } = useFeatures();
const isEnabled = flags.customFields && plus;
const { plus } = useFeatures();
const isEnabled = plus;
TheAndrewJackson marked this conversation as resolved.
Show resolved Hide resolved

// This keeps track of the fides key that was initially passed in. If that key started out blank,
// then we know the API call will just 404.
Expand Down
6 changes: 0 additions & 6 deletions clients/admin-ui/src/flags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@
"production": false,
"test": false
},
"customFields": {
"description": "Custom fields can be added to many forms throughout Fides. You can create, show, and hide custom fields that you add to Fides at any time.",
"development": true,
"test": true,
"production": false
},
"organizationManagement": {
"description": "Management page to configure Organization details for RoPA reporting, messaging, etc.",
"development": true,
Expand Down