Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove customField feature flag #3080

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Remove customField feature flag #3080

merged 3 commits into from
Apr 17, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Apr 17, 2023 •
edited
Loading

Closes #3046

Code Changes

  • Remove customFields feature flag

Steps to Confirm

  • Confirm that custom fields always show up on the system info tab and in the taxonomy view

Pre-Merge Checklist

Description Of Changes

Screenshot 2023-04-17 at 12 06 54

Screenshot 2023-04-17 at 12 06 39

@TheAndrewJackson TheAndrewJackson self-assigned this Apr 17, 2023
@cypress
Copy link

cypress bot commented Apr 17, 2023 •
edited
Loading

Passing run #1374 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge f6d9713 into 5247091...
Project: fides Commit: 47ee812255 ℹ️
Status: Passed Duration: 00:55 💡
Started: Apr 17, 2023 4:46 PM Ended: Apr 17, 2023 4:47 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review April 17, 2023 16:21
allisonking
allisonking approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

clients/admin-ui/src/features/common/custom-fields/hooks.ts Outdated Show resolved Hide resolved
@TheAndrewJackson TheAndrewJackson merged commit 34df89a into main Apr 17, 2023
@TheAndrewJackson TheAndrewJackson deleted the ajackson_3046_remove_custom_field_feature_flag branch April 17, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

Assignees

@TheAndrewJackson TheAndrewJackson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove feature flag for custom fields
2 participants
@TheAndrewJackson @allisonking