Fix 'TypeError: this is undefined'

[danielattilasimon]

Because populateCallTransaction is not called as a method, this line of code was throwing TypeError: this is undefined at runtime for me in the browser. I still don't understand why my tests are passing though...

Any ideas? Is this a valid fix?

UPDATE: hmm, could be that during tests the from override is never set.

[ricmoo]

(I'm adding testing to further make sure everything else works too)

[ricmoo]

This should be fixed in 5.0.0-beta.190.

There was quite. bit of refactoring, but there are now more tests in place to catch these. I still need to add a lot more tests, but for now this should cover the obvious things.

Let me know! :)

[danielattilasimon]

Awesome, this seems to be fixed, thanks!

One thing I noticed in the new version is, if I pass { blockTag: undefined } as overrides to a call now, it throws:

Error: cannot override "blockTag" (operation="overrides", overrides=["blockTag"], code=UNSUPPORTED_OPERATION, version=contracts/5.0.0-beta.155)

I will change my code so it only includes blockTag in overrides if it's not undefined, but is this intended behavior?

Thanks again for the quick fix!

[ricmoo]

Eek. I’ll add a test case and a fix for that in the morning. :)

Thanks for all the testing. :)

[danielattilasimon]

Cool, thanks so much!

No worries, I love using Ethers 5 :)

[ricmoo]

This should be fixed in 5.0.0-beta.191. Try it out and let me know. :)

[danielattilasimon]

Indeed it's fixed! Thanks so much! :)