V5 Beta, Overrides for Contract transactions not working

[crazyrabbitLTC]

I'm using the Ethersjs ^5.0.0-beta.188, and wondering if this is something I'm doing wrong, or what. The code worked previously when using V4, so not sure what I've done differently.

...
  const overrides = {
    gasLimit: estimatedGas,
    gasPrice,
    value: ethers.utils.parseEther("0"),
  }

try {
 const methodResult = await method(...methodParams, overrides)
} catch...

Gives the following error:

{
  "reason": "contract method is not payable",
  "code": "INVALID_ARGUMENT",
  "argument": "sendTransaction:shouldNotRevert(string)",
  "value": {
    "gasLimit": {
      "_hex": "0xa906",
      "_isBigNumber": true
    },
    "gasPrice": {
      "_hex": "0x3b9aca00",
      "_isBigNumber": true
    },
    "value": {
      "_hex": "0x00",
      "_isBigNumber": true
    },
    "to": {},
    "data": "0xd87f6dac00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000004706c706c00000000000000000000000000000000000000000000000000000000"
  }
}

The argument I am passing is is a normal string. (It is not the string value listed as the argument)
It is true this function method is not payable, but I am also not sending any value to it. (Value is 0). Additionally I think there might be a bug because the argument is listed as the function selector itself, which doesn't make sense to me.

Thoughts?

[ricmoo]

I think this is a bug. I check whether value is defined, and if so, fail. I should add an additional check, that if it is defined, that is is zero.

For now, removing the value should fix it and I’ll add a fix tomorrow.

The difference from v4 to v5 that is probably affecting you is that in v4, if the abi didn’t specify payable or mutabilityState it would default to payable (old Solidity semantics) whereas in v5, it defaults to non-payable (modern Solidity semantics).

[crazyrabbitLTC]

"The difference from v4 to v5 that is probably affecting you is that in v4, if the abi didn’t specify payable or mutabilityState it would default to payable (old Solidity semantics) whereas in v5, it defaults to non-payable (modern Solidity semantics)."

Is this going to be a problem going forward? I'm building a generalized factory for code that will generate front ends for any smart contract. I don't have the ability to control what version of Solidity the users smart contracts are written in.

Thanks!

[ricmoo]

If they are using a compiler /that/ old, they will likely have a lot of unaddressed security issues to deal with too.

They can easily resolve this though, by adding stateMutability to “payable” to all their functions though.

So, it provides additional safety to anyone using a contract written in the last 3-ish years, but there are simple solutions for people using ABIs generated older than that.

[ricmoo]

This should be fixed in 5.0.0-beta.189. Please try it out and let me know if you are still having problems.

[crazyrabbitLTC]

Seems to work! Thank you!