Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar ipfs support #2271

Closed
wants to merge 4 commits into from
Closed

Avatar ipfs support #2271

wants to merge 4 commits into from

Conversation

tlammens
Copy link

@tlammens tlammens commented Nov 5, 2021

No description provided.

@tlammens
Resolve avatar urls according to CAIP-22 where the tokenURI on the co…
5b67877 
…ntract it refers to is an IPFS URI and the image inside the metadata could be on IPFS as well.
@tlammens
Resolve avatar urls according to CAIP-22 where the tokenURI on the co…
9dcb780 
…ntract it refers to is an IPFS URI and the image inside the metadata could be on IPFS as well.
@tlammens
Copy link
Author

tlammens commented Nov 5, 2021

When the avatar field conforms to CAIP-22 and the tokenURI is requested it can return an IPFS URI referring to the metadata JSON as per ERC721.
The image inside the metadata JSON can also be a IPFS URI.
This pull request adds support for this use case.
Referring to #2185

@tlammens tlammens mentioned this pull request Nov 5, 2021
Closed
@ricmoo
Copy link
Member

ricmoo commented Dec 1, 2021

Do you have any test cases for these? I just need som examples on mainnet to test against.

@tlammens
Copy link
Author

tlammens commented Dec 1, 2021

Do you have any test cases for these? I just need som examples on mainnet to test against.

I did a limited search on mainnet, here is one that matches the use case:
j1mmy.eth
avatar set to: eip155:1/erc721:0xbc4ca0eda7647a8ab7c2061c2e118a18a936f13d/8824

I also have test contracts on rinkeby but they are not production ready.

@tlammens
Copy link
Author

tlammens commented Dec 1, 2021

Resolved the merge conflict

@ethers-io ethers-io deleted a comment Dec 4, 2021
@ethers-io ethers-io deleted a comment Dec 4, 2021
@ethers-io ethers-io deleted a comment Dec 4, 2021
@ethers-io ethers-io deleted a comment Dec 4, 2021
@christopherdro christopherdro mentioned this pull request Jan 11, 2022
Closed
@ricmoo ricmoo mentioned this pull request Jan 24, 2022
Closed
ricmoo added a commit that referenced this pull request Jan 25, 2022
@ricmoo
Support invalid but popular IPFS URI format (#2271, #2527, #2590).
03545aa
@ricmoo
Copy link
Member

ricmoo commented Jan 31, 2022

This should be fixed as of 5.5.4. Try it out and let me know if there are still any issues.

Thanks! :)

@ricmoo ricmoo closed this Feb 1, 2022
@tmm tmm mentioned this pull request Apr 4, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tlammens @ricmoo