Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] ENS IPFS avatars cannot be loaded #59

Closed
1 task done
sprice opened this issue Jan 9, 2022 · 5 comments
Closed
1 task done

[bug] ENS IPFS avatars cannot be loaded #59

sprice opened this issue Jan 9, 2022 · 5 comments

Comments

@sprice
Copy link

sprice commented Jan 9, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Package Version

0.1.2

Current Behavior

Using the example code from https://wagmi-xyz.vercel.app/guides/connect-wallet, I am connecting to my Ethereum wallet which has an ENS entry

The avatar does not display and the console reads Fetch API cannot load ipfs://QmPMc4tcBsMqLRuCQtPmPe84bpSjrC3Ky7t3JWuHXYB4aS/8929. URL scheme "ipfs" is not supported.

Expected Behavior

That my ENS avatar displays correctly

Steps To Reproduce

Run the example code from the wagmi docs (https://wagmi-xyz.vercel.app/guides/connect-wallet) and connect to an Ethereum address that has an ENS entry with an avatar set according to these docs

Anything else?

This package is amazing! Thank you.

@sprice
Copy link
Author

sprice commented Jan 9, 2022

I just realized i can connect to Metamask on the https://wagmi-xyz.vercel.app/guides/connect-wallet page and the same error occurs in the Console.

@0xOlias
Copy link

0xOlias commented Jan 9, 2022

The ENS avatar field format spec supports several URI types, most of which are not compatible with <img> tags out-of-the-box. If you're looking for a quick and effective solution, take a look at the davatar library.

I think the wagmi docs should probably remove the incorrect usage of the ENS avatar <img> tag from the guide. wagmi could also consider offering a <img>-ready URI by re-implementing some of the functionality of davatar, but I'm not sure if that's aligned with wagmi's goals.

@peduarte
Copy link
Contributor

semiwhat related: #33

@tmm
Copy link
Member

tmm commented Apr 4, 2022

@tmm tmm closed this as completed Apr 4, 2022
Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest wagmi version. If you have any other comments you can create a new discussion.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants