contracts: fix bad prototype logic

[ChALkeR]

Otherwise, if event.name === "__proto__", this logic would hit a setter and wouldn't do what it's expected to do.

This fix should affect anything else as the unique**** objects are local, temporary and references to them are not exported outside of the function.

Some other packages have similar issues, but it's a bit harder to fix them there without bumping to modern es, I'll file separate PRs later.

[ricmoo]

This was brought up in #2091, but I don't think it poses any significant issues, does it? The notes on MDN regarding Object.create(null) sounds more like it could raise other issues, especially on more obscure environments, which I don't have access to test on.

It will be fixed in v6 though, which uses ES5 modules (targeted for ES2016), so Maps and such are available, as well as Proxy, which handles most of this.

[ChALkeR]

Where can I see the v6 branch?

Alternatively, this could be fixed by using Set/Map, of course.

[ricmoo]

Set/Map are not available in the target environments for v5, unfortunately.

The v6 branch is still local on my machine and not available to the public. I’m frantically working my days away trying to get it ready for a public beta though. :)

Which is why I’m trying to punt more minor feature requests against v5, so that I have more time to work on it and many of those feature requests are moot in v6. :)

[ricmoo]

This should be fixed in 5.5.0. Please try it out and let me know.

Thanks!

[ricmoo]

This should be fixed in 5.5.0. Please try it out and let me know.

Thanks!

[ricmoo]

This should be fixed in 5.5.0. Please try it out and let me know.

Thanks!

[ricmoo]

@Tulle121 can you provide an example of what is not working along with any error?

[Tulle121]

resolved human error