Contracts with toString() functions panic when deployed

[RyanRHall]

Describe the bug
ethers fails to deploy contracts with a toString() function. (I was developing a library, but I assume normal contracts have the same issue). There are probably other function names that conflict with native js functions. valueOf() is likely another one.

Reproduction steps
Create a contract with a toString() function

library MyLibrary {
    function toString(uint256 value) public returns(string){
        // ...
    }
}

Then, attempting to deploy that contract using ethers and hardhat...

const myLibFactory = await ethers.getContractFactory('MyLibrary')
const myLib = await myLibFactory.deploy() // errors

yields this error message:

TypeError: uniqueNames[name_1].push is not a function
at /.../@ethersproject/contracts/src.ts/index.ts:717:35

Environment:
Hardhat 2.4.1, ethers 5.4.6

[zemse]

Can be reproduced with

new ethers.Contract(
  '0x0000000000000000000000000000000000000000', 
  ['function toString() external']
)

[ricmoo]

This should be fixed in 5.5.0. Please try it out and let me know if you still have any issues.

[ricmoo]

This should be fixed in 5.5.0. Please try it out and let me know if you still have any issues.

[pepperstepper]

Upgrading from 5.4.5 to 5.5.1 solved this issue for me!

[oceanbluu]

trying to read valueOf function from a contract using version 5.5.2 with:

let myContract = new ethers.Contract(address, abi, provider);
let value = await myContract.valueOf(xxxx, xxxx);

.. that doesnt seem to fly. im noob though, but spent few hours on this without finding any fault in my code.
I suspect valueOf is a keyword and it wrecks it.
Visual Studio Code marks the await word with "await has no effect on this type of expression", and upon running the code it returns some big object that seems way off expected result VSC's warning message goes away if I change the function name away from "valueOf".

[ricmoo]

The method valueOf is an existing JavaScript method on objects.

You must use the fully qualified method to access this name:

await contract["valueOf(address,uint256)"](addr, val)

as an example, if your method took in an address and uint.

[RyanRHall]

Closing, as this seems to be fixed in 5.5.X. Thank you @ricmoo.