Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Revert eth.fee_history #2103

Closed
wants to merge 5 commits into from

Conversation

kclowes
Copy link
Collaborator

@kclowes kclowes commented Aug 11, 2021

What was wrong?

Geth has the fee history endpoint implemented inconsistently, but they have the PR up to fix. We'll put this endpoint and docs back once 1.10.7 is out.

How was it fixed?

Removed the squashed commit (d722f31), and the doc commits that followed.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@banteg
Copy link
Contributor

banteg commented Aug 11, 2021

There are other clients which implement it correctly though like Erigon and Hardhat.

Web3.py also uses an incorrect formatter for eth_feeHistory input. It should be to_hex_if_integer for both args if two args are specified, and an array of floats for the third arg if it's specified.

@kclowes
Copy link
Collaborator Author

kclowes commented Aug 11, 2021

@banteg Do you know if Erigon can take an int for the first param?

The majority of people use Geth (according to Etherscan), so we were thinking it will be less confusing if we just wait for the next Geth release to include this RPC method and then everything will be standard. Geth hasn't done a release in a while, so it should come out soon. But if you need feeHistory now for some reason, I could be convinced to fix the formatter and keep it in for this next release.

@kclowes
Copy link
Collaborator Author

kclowes commented Aug 11, 2021

Actually, running a quick manual test, it looks to me like the Geth and Erigon implementations are the same. I can't send in a hexstring on either one, but they both take either a base 10 or base 16 int. But, in Geth 1.10.7 they will accept a hexstring like the spec says (see ethereum/go-ethereum#23239, and ethereum/execution-apis#20). I'll raise an issue on Erigon and see if they will standardize too. I'm going to close this for now, and leave the formatter off of the blockCount arg so that users can explicitly pass in what their client wants, and add a note to the docs.

@kclowes kclowes closed this Aug 11, 2021
@kclowes kclowes deleted the remove-fee-history branch August 11, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants