Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_feeHistory validation of different clients before 1559 #20

Closed
juanfranblanco opened this issue Jul 21, 2021 · 1 comment
Closed
Labels
A-spec Area: specification C-bug Category: this is a bug, deviation, or other problem C-question Category: this is a question or request for clarification

Comments

@juanfranblanco
Copy link

There has been some issues with the RPC implementation with different inputs and outputs formats. If we could validate all of the clients before going live, and have further eyes on this, it will be great.

Clients tested:

Geth
Input: blockCount is not in Hex, this pull fixes it ethereum/go-ethereum#23239
Output: OldestBlock is not in Hex

Besu
Corrected on hyperledger/besu#2517
Seems ok.

**Open Ethereum / Parity"
Seems ok.

Others?

@lightclient lightclient added A-spec Area: specification C-bug Category: this is a bug, deviation, or other problem C-question Category: this is a question or request for clarification labels Jul 28, 2021
@lightclient
Copy link
Member

It appears that all the EL clients have resolved this issue with eth_feeHistory. Going forward, yes, we need to be vigilant that clients behave the same before going live. We've done some work since this issue was posted to be able to catch issues early, on all clients, automatically. This is done by running rpc-compat simulator in hive: https://github.com/ethereum/hive/tree/master/simulators/ethereum/rpc-compat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-spec Area: specification C-bug Category: this is a bug, deviation, or other problem C-question Category: this is a question or request for clarification
Projects
None yet
Development

No branches or pull requests

2 participants