Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth_feeHistory should take a hexstring for block_count instead of an int #2514

Closed
kclowes opened this issue Aug 11, 2021 · 1 comment
Closed

eth_feeHistory should take a hexstring for block_count instead of an int #2514

kclowes opened this issue Aug 11, 2021 · 1 comment

Comments

@kclowes
Copy link

kclowes commented Aug 11, 2021

System information

Erigon version: 2021.08.2-alpha

OS & Version: All

Expected behaviour

There's been some movement to standardize the parameters for the block_count argument for the eth_feeHistory RPC method. The spec says that clients should accept a hexstring representation of the block count, but currently Erigon only accepts integers.

See issues: ethereum/execution-apis#20, and ethereum/go-ethereum#23239

Backtrace

n/a
@AskAlexSharov
Copy link
Collaborator

here is PR: #2518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kclowes @AskAlexSharov