Bump SSZ #499
Bump SSZ #499
Conversation
hwwhww
force-pushed
the
bump_ssz
branch
2 times, most recently
from
19479cc to
0ba687b
Compare
|
@hwwhww not to delay things but do we want to wait for ethereum/py-ssz#58 to be incorporated -- should let us drop the it may change this PR to "Bump ssz to |
tests/eth2/beacon/conftest.py
Outdated
| # SSZ | ||
| @pytest.fixture(scope="function", autouse=True) | ||
| def override_length(config): | ||
| BeaconState._meta.container_sedes.field_name_to_sedes["latest_randao_mixes"].length = config.LATEST_RANDAO_MIXES_LENGTH # noqa: E501 |
There was a problem hiding this comment.
How about putting the field-name/vector length pairs in a dict and then setting all of them in a loop?
integration issue.
Fix the dependency between `BeaconBlockHeader`, `BeaconBlockBody` and `ProposerSlashing` by moving `BeaconBlockHeader` to `eth2/beacon/types/block_headers.py`
| @@ -80,6 +83,8 @@ | |||
| beacon_chain_config = BeaconChainConfig(chain_name='TestTestTest', genesis_data=genesis_data) | |||
| chain_class = beacon_chain_config.beacon_chain_class | |||
|
|
|||
| override_vector_length(XIAO_LONG_BAO_CONFIG) | |||
There was a problem hiding this comment.
/cc @ChihChengLiang, @mhchia
After this PR, it requires overriding SSZ Vector length from config before using eth2.beacon.types.* classes.
eth2/beacon/types/block_headers.py
Outdated
| def __repr__(self) -> str: | ||
| return '<BlockHeader #{0} {1}>'.format( | ||
| self.slot, | ||
| encode_hex(self.signing_root)[2:10], |
There was a problem hiding this comment.
| encode_hex(self.signing_root)[2:10], | |
| encode_hex(self.root)[2:10], |
IMO it could be confusing if we use the signing root here because it's possible that two headers only differ by their signature.
There was a problem hiding this comment.
That's a good point. I think that's because we now use signing_root as:
previous_block_root- the key in
ChainDB
We can output both signing_root and root.
hwwhww
force-pushed
the
bump_ssz
branch
2 times, most recently
from
db60596 to
304c96a
Compare
What was wrong?
Fixed #409, #365
Bump to the new SSZ.
Note that it requires ethereum/py-ssz#64 PR merged.
How was it fixed?
Vectorsedespy-sszrootproperty for the hash tree rootpy-sszsigning_rootpropertyssz.tree_hash_rootfor calculatingBeaconState.latest_active_index_rootsBeaconBlockHeader,BeaconBlockBodyandProposerSlashingare twisted together. This PR movesBeaconBlockHeadertoeth2/beacon/types/block_headers.pyso thatProposerSlashingcan importeth2.beacon.types.block_headersCute Animal Picture