Root and SignedRoot #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
pipermerriam
approved these changes
Apr 19, 2019
ralexstokes
approved these changes
Apr 23, 2019
ssz/sedes/signed_serializable.py
Outdated
| class SignedSerializable(BaseSerializable, metaclass=MetaSignedSerializable): | ||
|
|
||
| @property | ||
| def signed_root(self): |
There was a problem hiding this comment.
this is now called signing_root :)
ssz/sedes/serializable.py
Outdated
| field_attrs = None | ||
| container_sedes = None | ||
| class Meta(NamedTuple): | ||
|
|
There was a problem hiding this comment.
minor but i feel like we usually have no whitespace b/t class decl and class attrs
There was a problem hiding this comment.
👍 I don't like how it looks, but I do like conventions, so I removed the new lines for all classes I could find.
|
|
||
|
|
||
| class SignedMeta(NamedTuple): | ||
| has_fields: bool |
There was a problem hiding this comment.
example about formatting here
ssz/sedes/signed_serializable.py
Outdated
|
|
||
|
|
||
| class MetaSignedSerializable(MetaSerializable): | ||
|
|
There was a problem hiding this comment.
whitespace? i'll let you decide if you want to patch these up, not blocking merging imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
#44
How was it fixed?
roottoBaseSerializableSignedSerializablethat provides the propertysigned_root(builds on top of #57)
Cute Animal Picture