Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Fix validate_attestation_slot #352

Merged
merged 3 commits into from
Mar 7, 2019
Merged

Fix validate_attestation_slot #352

merged 3 commits into from
Mar 7, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Mar 2, 2019

What was wrong?

Fix #345

How was it fixed?

Sync with the latest spec logic:

    # Can't submit attestations that are too far in history (or in prehistory) 
    assert attestation.data.slot >= GENESIS_SLOT
    assert state.slot < attestation.data.slot + SLOTS_PER_EPOCH
    # Can't submit attestations too quickly
    assert attestation.data.slot + MIN_ATTESTATION_INCLUSION_DELAY <= state.slot

Cute Animal Picture

hedgehog-248827_640

@hwwhww hwwhww added the eth2.0 label Mar 2, 2019
@hwwhww hwwhww assigned djrtwo and unassigned djrtwo Mar 2, 2019
@hwwhww hwwhww requested a review from djrtwo March 2, 2019 18:41
@hwwhww hwwhww mentioned this pull request Mar 4, 2019
Closed
@hwwhww hwwhww force-pushed the fix_validate_attestation_slot branch from 941e785 to 6009997 Compare March 7, 2019 05:22
@hwwhww hwwhww requested a review from djrtwo March 7, 2019 05:53
@hwwhww hwwhww merged commit 55299f9 into ethereum:master Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ralexstokes ralexstokes ralexstokes left review comments

@djrtwo djrtwo djrtwo approved these changes

Assignees
No one assigned
Labels
eth2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix validate_attestation_slot
3 participants
@hwwhww @djrtwo @ralexstokes