Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Fix validate_attestation_slot #345

Closed
hwwhww opened this issue Mar 1, 2019 · 0 comments · Fixed by #352
Closed

Fix validate_attestation_slot #345

hwwhww opened this issue Mar 1, 2019 · 0 comments · Fixed by #352
Assignees

Comments

@hwwhww
Copy link
Contributor

hwwhww commented Mar 1, 2019

What is wrong?

https://github.com/ethereum/eth2.0-specs/blob/dev/specs/core/0_beacon-chain.md#attestations-1

  1. Add assertion for Verify that attestation.data.slot >= GENESIS_SLOT
    # Can't submit attestations that are too far in history (or in prehistory) 
    assert attestation.data.slot >= GENESIS_SLOT
    assert state.slot < attestation.data.slot + SLOTS_PER_EPOCH
    # Can't submit attestations too quickly
    assert attestation.data.slot + MIN_ATTESTATION_INCLUSION_DELAY <= state.slot
  1. Fix other assertions around MIN_ATTESTATION_INCLUSION_DELAY (Fix slot range for attestation inclusion consensus-specs#669)

How can it be fixed

Fill this in if you know how to fix it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant