correct postState to postStateHash in LegacyTests

[winsvega]

No description provided.

[holgerd77]

Is this really the correct PR description (title)? I am not seeing any reference to the LegacyTests location in the paths of the files touched?

[winsvega]

Look at commits title rather

0c02165

[holgerd77]

Still completely not getting what has happened here, If one is doing a search now there are 17 BlockchainTests now having a postStateHash field instead of postHash?

Anyhow, will include in the release notes with some additional linking.

[winsvega]

Just renaming.
Hash instead of post state when state is too huge. Like megabytes

[holgerd77]

Ah ok. This can be problematic though when people rely on the state name being there, so this is technically a breaking change.

Anyhow, have added to the release notes if someone needs to be aware of this.

[holiman]

It's also pretty useless, since the postStateHash is, by definition, the stateRoot of the last successfully imported block.
See

tests/LegacyTests/Constantinople/BlockchainTests/GeneralStateTests/stQuadraticComplexityTest/Create1000Byzantium_d0g1v0.json

Lines 25 to 69 in b5eb990

	"stateRoot" : "0x02cc7a727c343a6670a1bab878054691c55a8eb24c861ba9f2fa94fbfd286839",
	"timestamp" : "0x03e8",
	"transactionsTrie" : "0x11d570905f32c46c526a712794d2d4a5e35176ac6de48c8328c5ffe7aaeb10e8",
	"uncleHash" : "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347"
	},
	"rlp" : "0xf90264f901fba082da4cdc9cd2496fd51732db6b341f35129715f05fd329c4f9c5f6bd79840db0a01dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d4934794b94f5374fce5edbc8e2a8697c15331677e6ebf0ba002cc7a727c343a6670a1bab878054691c55a8eb24c861ba9f2fa94fbfd286839a011d570905f32c46c526a712794d2d4a5e35176ac6de48c8328c5ffe7aaeb10e8a0fc78708222acd2631194cb68d6611a101c567921b40b0cf0614667b4cc2f9f60b90100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008302000001850200999600840236a48b8203e880a00000000000000000000000000000000000000000000000000000000000000000880000000000000000f863f8618001840ee6b28094bbbf5374fce5edbc8e2a8697c15331677e6ebf0b0a801ca059a4b49695baa04705375b29fcf0cfc663d0c3da6c748b0a1f6cab3158c4ff37a05b8cf80c815cb88b89b4e36f05acf96449cf50a69119f5a5b206d80cee938c69c0",
	"transactions" : [
	{
	"data" : "0x",
	"gasLimit" : "0x0ee6b280",
	"gasPrice" : "0x01",
	"nonce" : "0x00",
	"r" : "0x59a4b49695baa04705375b29fcf0cfc663d0c3da6c748b0a1f6cab3158c4ff37",
	"s" : "0x5b8cf80c815cb88b89b4e36f05acf96449cf50a69119f5a5b206d80cee938c69",
	"to" : "0xbbbf5374fce5edbc8e2a8697c15331677e6ebf0b",
	"v" : "0x1c",
	"value" : "0x0a"
	}
	],
	"uncleHeaders" : [
	]
	}
	],
	"genesisBlockHeader" : {
	"bloom" : "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
	"coinbase" : "0xb94f5374fce5edbc8e2a8697c15331677e6ebf0b",
	"difficulty" : "0x020000",
	"extraData" : "0x42",
	"gasLimit" : "0x0200999600",
	"gasUsed" : "0x00",
	"hash" : "0x82da4cdc9cd2496fd51732db6b341f35129715f05fd329c4f9c5f6bd79840db0",
	"mixHash" : "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
	"nonce" : "0x0102030405060708",
	"number" : "0x00",
	"parentHash" : "0x0000000000000000000000000000000000000000000000000000000000000000",
	"receiptTrie" : "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
	"stateRoot" : "0xc6109b7f20f60b581cbd39ade26067048097c6e906e83093d035a65131323086",
	"timestamp" : "0x03b6",
	"transactionsTrie" : "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421",
	"uncleHash" : "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347"
	},
	"genesisRLP" : "0xf901fcf901f7a00000000000000000000000000000000000000000000000000000000000000000a01dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d4934794b94f5374fce5edbc8e2a8697c15331677e6ebf0ba0c6109b7f20f60b581cbd39ade26067048097c6e906e83093d035a65131323086a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421b90100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008302000080850200999600808203b642a056e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421880102030405060708c0c0",
	"lastblockhash" : "0x70794b13a20645be2893a2a7990cdd7c6bd59feb8dda70e49820e8f4011654ee",
	"network" : "Byzantium",
	"postStateHash" : "0x02cc7a727c343a6670a1bab878054691c55a8eb24c861ba9f2fa94fbfd286839",