Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release v7.0.0-beta.1 #640

Merged
merged 1 commit into from
Oct 4, 2019
Merged

New release v7.0.0-beta.1 #640

merged 1 commit into from
Oct 4, 2019

Conversation

holgerd77
Copy link
Contributor

Always hoped that the release process would be continued somewhat automatically by the new contributors. Seems that wasn't be the case, so I sat down the evening and compiled down some new release notes myself.

@winsvega @holiman Is this a good time for a new release? Or should I wait for some others PRs to be merged and then update the release notes?

Cheers
Holger

@winsvega
Copy link
Collaborator

oh, should I keep the change log with every new PR so making this release notes would be easier ?

the tests for Istanbul are not finalazied yet. BlockchainTests would be regenerated. New tests could be added. I would suggest to fnalize the release notes a few days before the actual fork.

@holgerd77
Copy link
Contributor Author

@winsvega Ah, no, we need a release now to start testing, releasing a few days before the fork would be too late. That's what the beta releases should normally before (last time we just didn't made it to the final release 😛). We can do further beta releases if necessary like last time or then do a final v7.0.0 release once all Istanbul tests are ready.

@winsvega
Copy link
Collaborator

Ok then. One pr to merge is blake2f tests from shemnon. And it could be a beta release. The branch is develop.

@holgerd77 holgerd77 force-pushed the new-release-v700-beta1 branch from 89530bf to 9b0cab7 Compare September 23, 2019 20:32
@holgerd77
Copy link
Contributor Author

@winsvega Ok, great! 😄 Now rebased on top of the just merged Blake2bf PR, let me know if anything else is missing.

@holgerd77
Copy link
Contributor Author

Can this be merged now? Or is something missing?

@winsvega
Copy link
Collaborator

Yes. as a beta.

TODO:
BlockchainTests for istanbul regeneration
TransitionTests
New tests (if any)

@holgerd77
Copy link
Contributor Author

Ah, just saw, #637 is currently probably still a blocker until fixed?

@winsvega
Copy link
Collaborator

it is fixed.

@holgerd77
Copy link
Contributor Author

Ok, do I still need to update something here? The release is already labeled as a beta.

@winsvega
Copy link
Collaborator

winsvega commented Sep 25, 2019

its fine. it looks pretty descriptive

@winsvega
Copy link
Collaborator

winsvega commented Sep 25, 2019

wait. I found a couple of issues
#642

@holiman
Copy link
Contributor

holiman commented Sep 25, 2019

oh, should I keep the change log with every new PR so making this release notes would be easier ?

What you should do, imo, is write a detailed description on every PR.

@gumb0
Copy link
Member

gumb0 commented Sep 25, 2019

oh, should I keep the change log with every new PR so making this release notes would be easier ?

What you should do, imo, is write a detailed description on every PR.

I think you should do both of these.

@holgerd77
Copy link
Contributor Author

@winsvega Can you also merge here? I don't have sufficient permissions.

@winsvega
Copy link
Collaborator

Need to remove circle CI error build. It stops the pr from merging from phone

@holgerd77
Copy link
Contributor Author

@winsvega What's the status of this? I interpreted your message on CI from above as something you need to do, is this correct? Or do I need to push again the branch or something or adopt the PR in some way?

@winsvega winsvega merged commit cfbcd15 into develop Oct 4, 2019
@winsvega
Copy link
Collaborator

winsvega commented Oct 4, 2019

No. I just was trying to merge it from the mobile view.

@holgerd77
Copy link
Contributor Author

Ah ok.

@holgerd77
Copy link
Contributor Author

Ok, have done the release (as always here on the repo as a tag) and posted an associated post on Reddit.

@holgerd77
Copy link
Contributor Author

@winsvega Didn't follow too closely here lately but seems there have been significant PR merges since the last beta release regarding Istanbul changes like e.g. #649 and at the same time there are at least atm no significant PRs left open, would it eventually be time for another beta release? Then I would prepare some release notes on this.

Or are you eventually even ready that this could be marked as final Istanbul release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants