-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release v7.0.0-beta.1 #640
Conversation
oh, should I keep the change log with every new PR so making this release notes would be easier ? the tests for Istanbul are not finalazied yet. BlockchainTests would be regenerated. New tests could be added. I would suggest to fnalize the release notes a few days before the actual fork. |
@winsvega Ah, no, we need a release now to start testing, releasing a few days before the fork would be too late. That's what the beta releases should normally before (last time we just didn't made it to the final release 😛). We can do further beta releases if necessary like last time or then do a final |
Ok then. One pr to merge is blake2f tests from shemnon. And it could be a beta release. The branch is develop. |
89530bf
to
9b0cab7
Compare
@winsvega Ok, great! 😄 Now rebased on top of the just merged Blake2bf PR, let me know if anything else is missing. |
Can this be merged now? Or is something missing? |
Yes. as a beta. TODO: |
Ah, just saw, #637 is currently probably still a blocker until fixed? |
it is fixed. |
Ok, do I still need to update something here? The release is already labeled as a beta. |
its fine. it looks pretty descriptive |
wait. I found a couple of issues |
What you should do, imo, is write a detailed description on every PR. |
I think you should do both of these. |
@winsvega Can you also merge here? I don't have sufficient permissions. |
Need to remove circle CI error build. It stops the pr from merging from phone |
@winsvega What's the status of this? I interpreted your message on CI from above as something you need to do, is this correct? Or do I need to push again the branch or something or adopt the PR in some way? |
No. I just was trying to merge it from the mobile view. |
Ah ok. |
@winsvega Didn't follow too closely here lately but seems there have been significant PR merges since the last Or are you eventually even ready that this could be marked as final |
Always hoped that the release process would be continued somewhat automatically by the new contributors. Seems that wasn't be the case, so I sat down the evening and compiled down some new release notes myself.
@winsvega @holiman Is this a good time for a new release? Or should I wait for some others PRs to be merged and then update the release notes?
Cheers
Holger