Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RETURNCONTRACT validation tests #1391

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Jun 26, 2024

These tests are migrated to EEST in ethereum/execution-spec-tests#647

(To keep them here we would need to support "initcode" flag in EOF validation tests, and it seems not worth the effort to do it at this point, it's easier to just remove).

@winsvega
Copy link
Collaborator

we have introduced coverage checkup. if you add converted json files to ethereum-converte-tests file in pyspecs. it will measure the coverage of eof tests on pyspec version vs this .json you are about to remove, please try it out.

@chfast
Copy link
Member

chfast commented Jun 28, 2024

we have introduced coverage checkup. if you add converted json files to ethereum-converte-tests file in pyspecs. it will measure the coverage of eof tests on pyspec version vs this .json you are about to remove, please try it out.

This doesn't work: https://github.com/ethereum/execution-spec-tests/actions/runs/9715118299

@winsvega
Copy link
Collaborator

again?
ethereum/execution-spec-tests#657

@chfast
Copy link
Member

chfast commented Jul 1, 2024

again? ethereum/execution-spec-tests#657

This is not merged? 🤷

@chfast
Copy link
Member

chfast commented Jul 1, 2024

@winsvega Can you make an example migration PR? It looks you made a tool for migration but it is untested.

@winsvega
Copy link
Collaborator

winsvega commented Jul 1, 2024

You mean the coverage?
Its in pyspec repo closed PRs titled TEST
ethereum/execution-spec-tests#656

@winsvega
Copy link
Collaborator

winsvega commented Jul 1, 2024

again? ethereum/execution-spec-tests#657

This is not merged? 🤷

I can't merge without review.

You can just add these changes to your pr.

@chfast
Copy link
Member

chfast commented Jul 1, 2024

You can just add these changes to your pr.

I did, but it seems the evmone used is out of date. I'm not sure how to read this report.

@winsvega
Copy link
Collaborator

winsvega commented Jul 4, 2024

the coverage check didn't complete, but its eof tests so let it go.

Error: Contents of /home/travis/build/ethereum/tests/src/EOFTestsFiller/efValidation/EOF1_returncontract_valid_Copier.json is empty. Trying to parse empty file. (forgot --filltests?) (EOFTests/efValidation/EOF1_returncontract_valid_Copier, step: CheckFiller)
Error: 
Error when parsing file (/home/travis/build/ethereum/tests/src/EOFTestsFiller/efValidation/EOF1_returncontract_valid_Copier.json) Contents of /home/travis/build/ethereum/tests/src/EOFTestsFiller/efValidation/EOF1_returncontract_valid_Copier.json is empty. Trying to parse empty file. (forgot --filltests?) 

the source and the generated test files must be removed.

@gumb0 gumb0 force-pushed the remove-returncontract-tests branch from 5f6c324 to b444f33 Compare July 5, 2024 09:50
@gumb0 gumb0 force-pushed the remove-returncontract-tests branch from b444f33 to eb2afa4 Compare July 5, 2024 09:52
@gumb0
Copy link
Member Author

gumb0 commented Jul 5, 2024

the source and the generated test files must be removed.

fixed

@winsvega winsvega merged commit d608160 into ethereum:develop Jul 8, 2024
2 checks passed
@gumb0 gumb0 deleted the remove-returncontract-tests branch July 9, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants