-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove RETURNCONTRACT validation tests #1391
Conversation
we have introduced coverage checkup. if you add converted json files to ethereum-converte-tests file in pyspecs. it will measure the coverage of eof tests on pyspec version vs this .json you are about to remove, please try it out. |
This doesn't work: https://github.com/ethereum/execution-spec-tests/actions/runs/9715118299 |
This is not merged? 🤷 |
@winsvega Can you make an example migration PR? It looks you made a tool for migration but it is untested. |
You mean the coverage? |
I can't merge without review. You can just add these changes to your pr. |
I did, but it seems the evmone used is out of date. I'm not sure how to read this report. |
the coverage check didn't complete, but its eof tests so let it go.
the source and the generated test files must be removed. |
5f6c324
to
b444f33
Compare
b444f33
to
eb2afa4
Compare
fixed |
These tests are migrated to EEST in ethereum/execution-spec-tests#647
(To keep them here we would need to support "initcode" flag in EOF validation tests, and it seems not worth the effort to do it at this point, it's easier to just remove).