Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update_Chain_1149 #1057

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Update_Chain_1149 #1057

merged 5 commits into from
Jun 12, 2023

Conversation

symplexialabs
Copy link
Contributor

@symplexialabs symplexialabs commented Jun 9, 2023

Due some internal problems, the Chain 1149 had to be reset. Thus, we had to deploy new contracts-tests.

View in Huly HI-675

@kuzdogan
Copy link
Member

kuzdogan commented Jun 10, 2023

For a short time there was a problem with lerna on our CI jobs. Can you please merge or rebase from staging?

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -7.27 ⚠️

Comparison is base (d449b7a) 77.31% compared to head (f78dfd4) 70.04%.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1057      +/-   ##
===========================================
- Coverage    77.31%   70.04%   -7.27%     
===========================================
  Files           31       40       +9     
  Lines         1450     2270     +820     
  Branches       266      432     +166     
===========================================
+ Hits          1121     1590     +469     
- Misses         191      465     +274     
- Partials       138      215      +77     
Flag Coverage Δ
lib-sourcify 66.70% <ø> (?)
server 71.93% <ø> (-5.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourcify-chains.ts 84.94% <ø> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuzdogan
Copy link
Member

Since this is not a new chain, the tests don't run on the CI but checked the chain test locally.

@kuzdogan kuzdogan merged commit 67aae9d into ethereum:staging Jun 12, 2023
@kuzdogan
Copy link
Member

The RPCs have been unstable lately and the tests are failing. If not fixed we are going to have to remove support for this chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants