-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Symplexia Smart Chain (1149) #1007
Conversation
Hey @symplexialabs, first of all thanks for the contribution! 🙏 I see you added new sources for the tests. Existing contracts sources didn't work for some reason? Just for context, I see you followed point 5.ii in Sourcify's documentation, my question is: why points 5.i.a or 5.i.b or 5.i.c didn't work for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, I see you formatted the code. Can you please remove the additional white spaces
@symplexialabs did you see my comment regarding the test files?
|
|
As a matter of fact for testing I'm using option 5.i.a. However, at some point I submitted contracts using option 5.i.c just to see if it worked with REMIX. Now I am submitting new tests, considering that the network was under maintenance and some tests have failed. |
Dear Marco, I would like to know if I have to do anything else. Thanks. |
I'll check this tomorrow, sorry bu I've been busy today |
@symplexialabs The tests are failing as the test contract Can you please open a new PR that fixes the tests? Is the chain reset or how is this possible? If not resolved the chain support will be removed. |
Dear Kuzdogan, the test were failling because, due some problems, we had to reset the chain. I've have already commited the changes. |
|
The PR (Update_Chain_1149 #1057) was open as required. |
View in Huly HI-677