Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symplexia Smart Chain (1149) #1007

Merged
merged 9 commits into from
May 11, 2023

Conversation

symplexialabs
Copy link
Contributor

@symplexialabs symplexialabs commented Apr 28, 2023

View in Huly HI-677

@marcocastignoli
Copy link
Member

Hey @symplexialabs, first of all thanks for the contribution! 🙏

I see you added new sources for the tests. Existing contracts sources didn't work for some reason? Just for context, I see you followed point 5.ii in Sourcify's documentation, my question is: why points 5.i.a or 5.i.b or 5.i.c didn't work for you?

Copy link
Member

@marcocastignoli marcocastignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I see you formatted the code. Can you please remove the additional white spaces

@marcocastignoli
Copy link
Member

@symplexialabs did you see my comment regarding the test files?

I see you added new sources for the tests. Existing contracts sources didn't work for some reason? Just for context, I see you followed point 5.ii in Sourcify's documentation, my question is: why points 5.i.a or 5.i.b or 5.i.c didn't work for you?

@symplexialabs
Copy link
Contributor Author

Here, I see you formatted the code. Can you please remove the additional white spaces
I've removed the addtional white spaes, as you asked.

@symplexialabs
Copy link
Contributor Author

@symplexialabs did you see my comment regarding the test files?

I see you added new sources for the tests. Existing contracts sources didn't work for some reason? Just for context, I see you followed point 5.ii in Sourcify's documentation, my question is: why points 5.i.a or 5.i.b or 5.i.c didn't work for you?

As a matter of fact for testing I'm using option 5.i.a. However, at some point I submitted contracts using option 5.i.c just to see if it worked with REMIX. Now I am submitting new tests, considering that the network was under maintenance and some tests have failed.

@symplexialabs
Copy link
Contributor Author

Dear Marco, I would like to know if I have to do anything else. Thanks.

@marcocastignoli
Copy link
Member

I'll check this tomorrow, sorry bu I've been busy today

@marcocastignoli marcocastignoli merged commit 5f6a247 into ethereum:staging May 11, 2023
@kuzdogan
Copy link
Member

kuzdogan commented Jun 7, 2023

@symplexialabs The tests are failing as the test contract 0xa33a20ba0aC3fe6b94a8e1Eb4614947B9cb51F84 can not be found on the chain https://app.circleci.com/pipelines/github/ethereum/sourcify/4134/workflows/d9313144-4104-4744-8a7f-85f6a1863704/jobs/22675

Can you please open a new PR that fixes the tests? Is the chain reset or how is this possible? If not resolved the chain support will be removed.

@symplexialabs
Copy link
Contributor Author

Dear Kuzdogan, the test were failling because, due some problems, we had to reset the chain. I've have already commited the changes.

@symplexialabs
Copy link
Contributor Author

@symplexialabs The tests are failing as the test contract 0xa33a20ba0aC3fe6b94a8e1Eb4614947B9cb51F84 can not be found on the chain https://app.circleci.com/pipelines/github/ethereum/sourcify/4134/workflows/d9313144-4104-4744-8a7f-85f6a1863704/jobs/22675

Can you please open a new PR that fixes the tests? Is the chain reset or how is this possible? If not resolved the chain support will be removed.

@symplexialabs
Copy link
Contributor Author

The PR (Update_Chain_1149 #1057) was open as required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants