Deneb signing #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
|
The Teku implementation of these changes are covered via Consensys/teku#7428. The BlobSidecar is mapped to BlindedBlobSidecar by calculating the "hashroot/merkelization" of "blob". i.e. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces signing for the Deneb fork #2
Since changes for Deneb block are in the execution payload and web3signer uses the BeaconBlockHeader we don't need to make changes to the block type.
For blob sidecar signing we can use the blinded sidecar type for both using the blob_root instead of the full blob. So don't need to pass through as much data and can have one type instead of two. And the new blob sidecar type is actually a blinded blob sidecar. Thought that was clearer but maybe the name is confusing.
The new type also uses snake casing to be consistent with the consensus spec instead of using camel casing.