Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support signing BlobSidecar with Web3Signer #4453

Closed
jimmygchen opened this issue Jun 30, 2023 · 2 comments
Closed

Support signing BlobSidecar with Web3Signer #4453

jimmygchen opened this issue Jun 30, 2023 · 2 comments
Assignees
Labels

Comments

@jimmygchen
Copy link
Member

Description

Support Web3Signer signing for blob sidecars. Depends on this Web3Signer issue: Consensys/web3signer#726

Once the schema and signing is implemented in Web3Signer, the VC needs to construct a Web3SignerObject here:

SignableMessage::BlobSidecar(_) => {
// https://github.com/ConsenSys/web3signer/issues/726
unimplemented!("Web3Signer blob signing not implemented.")
}

@jimmygchen
Copy link
Member Author

Remote signing api spec PR merged here: ethereum/remote-signing-api#4

TL;DR:

For blob sidecar signing we can use the blinded sidecar type for both using the blob_root instead of the full blob.

@realbigsean realbigsean self-assigned this Oct 6, 2023
@michaelsproul michaelsproul mentioned this issue Oct 16, 2023
@realbigsean
Copy link
Member

Closing due to deprecation of blob signing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants