Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement command line argument to set the amount miner threads #345

Merged
merged 1 commit into from
Feb 19, 2015
Merged

Implement command line argument to set the amount miner threads #345

merged 1 commit into from
Feb 19, 2015

Conversation

maran
Copy link
Member

@maran maran commented Feb 19, 2015

Defaults to the amount of cores available on the CPU

Implement command line argument to set the amount of agents created b…
5aff8bf 
…y the miner

Defaults to the amount of cores available on the CPU
@tgerring
Copy link
Contributor

Should we check/limit/care if the user specifies more than CPU cores?

@fjl
Copy link
Contributor

fjl commented Feb 19, 2015

I don't think we should. It will simply not run faster in this case.

obscuren added a commit that referenced this pull request Feb 19, 2015
@obscuren
Merge pull request #345 from maran/feature/minerthreads
765740b 
Implement command line argument to set the amount miner threads
@obscuren obscuren merged commit 765740b into ethereum:develop Feb 19, 2015
ngtuna added a commit to ngtuna/tomochain that referenced this pull request Dec 19, 2018
@ngtuna
Merge pull request ethereum#345 from nguyenbatam/add_broadcast_log_wh…
a3ce354 
…en_insert_block

broadcast log when insert block
AusIV pushed a commit to NoteGio/go-ethereum that referenced this pull request Jul 12, 2021
@ziogaschr
Merge pull request ethereum#345 from etclabscore/feat/trace-state-diff
b5dcf86 
Implement stateDiff tracer, compatible with OpenEthereum
tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this pull request Jan 20, 2022
@marekolszewski
Temporarily disable checking phone hash commitments (ethereum#345)
56f21be 
* Temporarily disable checking phone hash commitments
@AndreiShybin AndreiShybin mentioned this pull request Nov 5, 2022
Open
@AndreiShybin AndreiShybin mentioned this pull request Dec 26, 2022
Open
tanishqjasoria pushed a commit to tanishqjasoria/go-ethereum that referenced this pull request Oct 31, 2023
@Thegaram @NazariiDenha
@maxwolff @icemelon @0xmountaintop
feat: Sync and relay L1 messages (ethereum#350)
983d630 
* add l1 config in genesis config (ethereum#249)

* add l1 config in genesis config

* fix lint

* Update params/config.go

Co-authored-by: Péter Garamvölgyi <[email protected]>

---------

Co-authored-by: Péter Garamvölgyi <[email protected]>

* extend node configuration (ethereum#251)

* extend node configuration

* use block number instead of hash

* accept safe, finalized and numbers for L1Confirmations

* fix typos

---------

Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>

* Fix/improve node config parsing (ethereum#260)

* raise error on failed parsing

* default value

* add l1-message-type, transaction methods (ethereum#252)

* add l1-message-type, transaction methods

* goimports

* Update core/types/transaction.go

Co-authored-by: Péter Garamvölgyi <[email protected]>

* txpool l1 check, pointer change, marhsal test

* draft: start implementing l1message gas behavior

* draft: start implementing l1message gas behavior

* change to gas usage

* error comment typo

Co-authored-by: Haichen Shen <[email protected]>

* goimports

* update nonce, add hash test (fails), marshal test

* goimports

* target addr cant be nil

* change call msg

* comment out test

* lint

---------

Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>

* Add L1 message database (ethereum#255)

* add l1-message-type, transaction methods

* goimports

* Update core/types/transaction.go

Co-authored-by: Péter Garamvölgyi <[email protected]>

* add L1 message store to rawdb

* remove comments

* rename to l1_message

* rename variables and add comments

* write l1 msgs in a batch

* add more comments

* update tests

* allow batched and non-batched writes

* rename to accessors_l1_message

* handle error

* add range check

* fix tests

* update comments

* nit

* support blocks with 0 l1 messages

---------

Co-authored-by: Max Wolff <[email protected]>
Co-authored-by: Max Wolff <[email protected]>

* Fix L1Message Deep Copy, Complete Bridge Tx Hash test (ethereum#269)

* deep copy value field, add tx hash test

comment

* typo

* Rename nonce to queueindex, increment sender nonce on L1 message execution (ethereum#271)

* change nonce to queueindex, increment nonce on L1 message

* fix db acccessors

* Update core/types/transaction_marshalling.go

Co-authored-by: Péter Garamvölgyi <[email protected]>

---------

Co-authored-by: Péter Garamvölgyi <[email protected]>

* Fix db inspect command (ethereum#276)

fix db inspect command

* Add l1 sync service (ethereum#256)

* extend node configuration

* add l1-message-type, transaction methods

* goimports

* Update core/types/transaction.go

Co-authored-by: Péter Garamvölgyi <[email protected]>

* use block number instead of hash

* accept safe, finalized and numbers for L1Confirmations

* add L1 message store to rawdb

* remove comments

* fix typos

* add L1 message sync service

* use l1 contract address and chain ID

* use L1DeploymentBlock

* add confirmation config

* move bridge client to separate file

* use uint64 block number

* fix bigint comparison

* rename constants

* add more logs

* rename to l1_message

* rename variables and add comments

* write l1 msgs in a batch

* add more comments

* update tests

* allow batched and non-batched writes

* rename to accessors_l1_message

* handle error

* check if config is provided

* improve sync service DB batched writes

* add range check

* fix tests

* update comments

* nit

* fix flush range and improve comments

* solve circular dependency

* update stress tests

* initialize l1 client for geth

* start sync service

* add more comments

* check nil correctly

* address comments

* fix merge

* fix genesis l1config deserialization

* add sync progress logs

* initial sync

* handle leveldb not found error

* use errors.Is

* address comments

* update DefaultPollInterval

---------

Co-authored-by: Nazarii Denha <[email protected]>
Co-authored-by: Max Wolff <[email protected]>
Co-authored-by: Max Wolff <[email protected]>

* Add L1 message validation (ethereum#272)

* add L1 message validation

* add comments and better error handling

* handle leveldb not found error

* update incorrect condition for genesis block

* typo

* change inclusion index logic

* disable L1 message check for legacy tests

* set NumL1MessagesPerBlock to 0 in tests

* update default genesis config

* Add L1 msg validation tests (ethereum#303)

add L1 msg validation tests

* Update miner include l1 messages (ethereum#265)

* add l1-message-type, transaction methods

* goimports

* Update core/types/transaction.go

Co-authored-by: Péter Garamvölgyi <[email protected]>

* add L1 message store to rawdb

* add L1 message sync service

* remove comments

* use l1 contract address and chain ID

* extend node configuration

* use block number instead of hash

* accept safe, finalized and numbers for L1Confirmations

* fix typos

* use L1DeploymentBlock

* add confirmation config

* move bridge client to separate file

* use uint64 block number

* fix bigint comparison

* rename constants

* add more logs

* Fix/improve node config parsing (ethereum#260)

* raise error on failed parsing

* default value

* rename to l1_message

* rename variables and add comments

* write l1 msgs in a batch

* add more comments

* update tests

* allow batched and non-batched writes

* rename to accessors_l1_message

* handle error

* check if config is provided

* improve sync service DB batched writes

* include l1 messages in blocks: part 1

* add l1-message-type, transaction methods (ethereum#252)

* add l1-message-type, transaction methods

* goimports

* Update core/types/transaction.go

Co-authored-by: Péter Garamvölgyi <[email protected]>

* txpool l1 check, pointer change, marhsal test

* draft: start implementing l1message gas behavior

* draft: start implementing l1message gas behavior

* change to gas usage

* error comment typo

Co-authored-by: Haichen Shen <[email protected]>

* goimports

* update nonce, add hash test (fails), marshal test

* goimports

* target addr cant be nil

* change call msg

* comment out test

* lint

---------

Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>

* Add L1 message database (ethereum#255)

* add l1-message-type, transaction methods

* goimports

* Update core/types/transaction.go

Co-authored-by: Péter Garamvölgyi <[email protected]>

* add L1 message store to rawdb

* remove comments

* rename to l1_message

* rename variables and add comments

* write l1 msgs in a batch

* add more comments

* update tests

* allow batched and non-batched writes

* rename to accessors_l1_message

* handle error

* add range check

* fix tests

* update comments

* nit

* support blocks with 0 l1 messages

---------

Co-authored-by: Max Wolff <[email protected]>
Co-authored-by: Max Wolff <[email protected]>

* build(docker): auto docker push when pushing git tags (ethereum#258)

* build(docker): update docker trigger tag prefix (ethereum#259)

* Fix L1Message Deep Copy, Complete Bridge Tx Hash test (ethereum#269)

* deep copy value field, add tx hash test

comment

* typo

* commitl1messages

* lint

* Revert "add L1 message sync service"

This reverts commit 5305e8a.

* Revert "move bridge client to separate file"

This reverts commit 0b220be.

* update branch

* use commitMessages for l1Txs

* little fix

* fix config

* fix test

* comment fixes

* fix

* fix config check

---------

Co-authored-by: Max Wolff <[email protected]>
Co-authored-by: Max Wolff <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>

* Add ErrUnknownAncestor tests (ethereum#305)

add ErrUnknownAncestor tests

* worker test include l1 msgs (ethereum#306)

* worker test include l1 msgs

* move L1 message index update next to block insertion

---------

Co-authored-by: Péter Garamvölgyi <[email protected]>

* exclude l1 messages from transaction count limit in block (ethereum#307)

* exclude l1 messages from transaction count limit in block

* fix comments

* trigger ci

* nit

---------

Co-authored-by: Péter Garamvölgyi <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>

* Expose queueIndex on Transaction (ethereum#316)

expose queueIndex on Transaction

* test that l1msg doesn't count in maxTxPerBlock limit (ethereum#312)

* test that l1msg doesn't count in maxTxPerBlock limit

* fix, comment

* retrigger ci

* change order inside test

---------

Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: Péter Garamvölgyi <[email protected]>

* reuse trace nonce field for queueIndex

* expose scroll APIs on the geth console

* add L1 message query APIs

* Trigger new block on new l1 messages (ethereum#343)

* trigger new block on new l1 messages

* typo

* initialize l1MsgCh

* fix worker l1msg tests (ethereum#345)

---------

Co-authored-by: Nazarii Denha <[email protected]>

* test(worker): ensure that l1 messages are included in the correct order (ethereum#346)

test that l1msgs added in correct order

* rename enqueueIndex --> queueIndex

* move QueueIndex into transaction

* improve l1 db interface

* formatting

* bump version

* print l1config

* add API to query latest included message queue index

* clean up tx limit logic

* add clarifying comments and todos to ValidateL1Messages

* improve db comments and logs

* clean up L1MessageTx type handling

* format

* format

* improve L1 message block check

* fix missing L1 event handling

* fix TestL1MessageValidationFailure

* simplify sync height resume logic

* make l1Config.l1MessageQueueAddress non-pointer

* improve command line flags

* remove todo

* use abigen tools for log filtering

* cache block L1 message count

* nit: fix variable name case

* improve logs

* flush pending writes to DB before shutdown

---------

Co-authored-by: Nazarii Denha <[email protected]>
Co-authored-by: Max Wolff <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: Max Wolff <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
mralj pushed a commit to NethermindEth/rollup-geth that referenced this pull request Oct 1, 2024
@bitwiseguy
Make OptimismConfig.EIP1559DenominatorCanyon optional (ethereum#345)
c6ea6fa 
* Make OptimismConfig.EIP1559DenominatorCanyon optional

* Simplify EIP1559DenominatorCanyon override logic

* Fix logic for EIP1559DenominatorCanyon override

* Use helper for creating uint64 pointer

* panic if invalid EIP1559DenominatorCanyon is detected

* Add test cases for OverrideOptimismCanyon

* go lint

* Make Override tests independent of each other and run in parallel
s1na pushed a commit to s1na/go-ethereum that referenced this pull request Dec 2, 2024
@liam-lai
add testnet block for v2 (ethereum#345)
64a2c84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maran @tgerring @fjl @obscuren