KeyStore (Low level key functionality) #259

Gustav-Simonsson · 2015-01-15T18:53:56Z

Old PR: #243
See commit messages for details.
Re-opened to use correct branch names.

* Add new generic key_store interface * Add new plaintext key store storing unprotected keys on disk * Add new encrypted key store storing encrypted keys on disk * Add new entropy mixing function using OS and go runtime sources

* Simplify scrypt constants with const block * Add key store constructors and make their types private * Simplify key store and file namings to be less Java Enterprise™ * Change test error logging to use t.Error(err) * Reduce number of naked returns (just like my ex-gf) * Simplify file reading path code

* Remove flags field from key struct * Change JSON struct fields from string to []byte * Change GenerateNewKey API to take io.Reader for random source * Remove mixing entropy source function * Use testing Fatal in tests

obscuren · 2015-01-19T09:42:09Z

crypto/key_store_passphrase.go

+
+func NewKeyStorePassphrase(path string) KeyStore2 {
+	ks := new(keyStorePassphrase)
+	ks.keysDirPath = path


ks := &keyStorePassphrase{ keysDirPath: path }

Use new for incremental population.

ebuchman · 2015-01-19T14:27:57Z

crypto/key.go

+	if err != nil {
+		panic("key generation: could not read from random source: " + err.Error())
+	} else {
+		if n != 32 {


Is this extra check necessary?

From the godocs: (http://golang.org/src/crypto/rand/rand.go?s=635:673#L9)
// On return, n == len(b) if and only if err == nil.

Correct, it's not needed. Removing.

* Allocate with composite literal instead of new * Remove check of number of bytes read from rand

fjl · 2015-01-19T19:55:16Z

crypto/key_store_passphrase.go

+		keysDirPath : path,
+	}
+	return ks
+}


You could write this without a variable:

return &keyStorePassphrase{path}

Just so you know.

* Further simplify "constructor" function's allocation of structs * Fix formatting

KeyStore (Low level key functionality)

remove useless code

* rollup: remove dead serialization logic * test: delete old test

* add l1 config in genesis config (ethereum#249) * add l1 config in genesis config * fix lint * Update params/config.go Co-authored-by: Péter Garamvölgyi <[email protected]> --------- Co-authored-by: Péter Garamvölgyi <[email protected]> * extend node configuration (ethereum#251) * extend node configuration * use block number instead of hash * accept safe, finalized and numbers for L1Confirmations * fix typos --------- Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> * Fix/improve node config parsing (ethereum#260) * raise error on failed parsing * default value * add l1-message-type, transaction methods (ethereum#252) * add l1-message-type, transaction methods * goimports * Update core/types/transaction.go Co-authored-by: Péter Garamvölgyi <[email protected]> * txpool l1 check, pointer change, marhsal test * draft: start implementing l1message gas behavior * draft: start implementing l1message gas behavior * change to gas usage * error comment typo Co-authored-by: Haichen Shen <[email protected]> * goimports * update nonce, add hash test (fails), marshal test * goimports * target addr cant be nil * change call msg * comment out test * lint --------- Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: Haichen Shen <[email protected]> * Add L1 message database (ethereum#255) * add l1-message-type, transaction methods * goimports * Update core/types/transaction.go Co-authored-by: Péter Garamvölgyi <[email protected]> * add L1 message store to rawdb * remove comments * rename to l1_message * rename variables and add comments * write l1 msgs in a batch * add more comments * update tests * allow batched and non-batched writes * rename to accessors_l1_message * handle error * add range check * fix tests * update comments * nit * support blocks with 0 l1 messages --------- Co-authored-by: Max Wolff <[email protected]> Co-authored-by: Max Wolff <[email protected]> * Fix L1Message Deep Copy, Complete Bridge Tx Hash test (ethereum#269) * deep copy value field, add tx hash test comment * typo * Rename nonce to queueindex, increment sender nonce on L1 message execution (ethereum#271) * change nonce to queueindex, increment nonce on L1 message * fix db acccessors * Update core/types/transaction_marshalling.go Co-authored-by: Péter Garamvölgyi <[email protected]> --------- Co-authored-by: Péter Garamvölgyi <[email protected]> * Fix db inspect command (ethereum#276) fix db inspect command * Add l1 sync service (ethereum#256) * extend node configuration * add l1-message-type, transaction methods * goimports * Update core/types/transaction.go Co-authored-by: Péter Garamvölgyi <[email protected]> * use block number instead of hash * accept safe, finalized and numbers for L1Confirmations * add L1 message store to rawdb * remove comments * fix typos * add L1 message sync service * use l1 contract address and chain ID * use L1DeploymentBlock * add confirmation config * move bridge client to separate file * use uint64 block number * fix bigint comparison * rename constants * add more logs * rename to l1_message * rename variables and add comments * write l1 msgs in a batch * add more comments * update tests * allow batched and non-batched writes * rename to accessors_l1_message * handle error * check if config is provided * improve sync service DB batched writes * add range check * fix tests * update comments * nit * fix flush range and improve comments * solve circular dependency * update stress tests * initialize l1 client for geth * start sync service * add more comments * check nil correctly * address comments * fix merge * fix genesis l1config deserialization * add sync progress logs * initial sync * handle leveldb not found error * use errors.Is * address comments * update DefaultPollInterval --------- Co-authored-by: Nazarii Denha <[email protected]> Co-authored-by: Max Wolff <[email protected]> Co-authored-by: Max Wolff <[email protected]> * Add L1 message validation (ethereum#272) * add L1 message validation * add comments and better error handling * handle leveldb not found error * update incorrect condition for genesis block * typo * change inclusion index logic * disable L1 message check for legacy tests * set NumL1MessagesPerBlock to 0 in tests * update default genesis config * Add L1 msg validation tests (ethereum#303) add L1 msg validation tests * Update miner include l1 messages (ethereum#265) * add l1-message-type, transaction methods * goimports * Update core/types/transaction.go Co-authored-by: Péter Garamvölgyi <[email protected]> * add L1 message store to rawdb * add L1 message sync service * remove comments * use l1 contract address and chain ID * extend node configuration * use block number instead of hash * accept safe, finalized and numbers for L1Confirmations * fix typos * use L1DeploymentBlock * add confirmation config * move bridge client to separate file * use uint64 block number * fix bigint comparison * rename constants * add more logs * Fix/improve node config parsing (ethereum#260) * raise error on failed parsing * default value * rename to l1_message * rename variables and add comments * write l1 msgs in a batch * add more comments * update tests * allow batched and non-batched writes * rename to accessors_l1_message * handle error * check if config is provided * improve sync service DB batched writes * include l1 messages in blocks: part 1 * add l1-message-type, transaction methods (ethereum#252) * add l1-message-type, transaction methods * goimports * Update core/types/transaction.go Co-authored-by: Péter Garamvölgyi <[email protected]> * txpool l1 check, pointer change, marhsal test * draft: start implementing l1message gas behavior * draft: start implementing l1message gas behavior * change to gas usage * error comment typo Co-authored-by: Haichen Shen <[email protected]> * goimports * update nonce, add hash test (fails), marshal test * goimports * target addr cant be nil * change call msg * comment out test * lint --------- Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: Haichen Shen <[email protected]> * Add L1 message database (ethereum#255) * add l1-message-type, transaction methods * goimports * Update core/types/transaction.go Co-authored-by: Péter Garamvölgyi <[email protected]> * add L1 message store to rawdb * remove comments * rename to l1_message * rename variables and add comments * write l1 msgs in a batch * add more comments * update tests * allow batched and non-batched writes * rename to accessors_l1_message * handle error * add range check * fix tests * update comments * nit * support blocks with 0 l1 messages --------- Co-authored-by: Max Wolff <[email protected]> Co-authored-by: Max Wolff <[email protected]> * build(docker): auto docker push when pushing git tags (ethereum#258) * build(docker): update docker trigger tag prefix (ethereum#259) * Fix L1Message Deep Copy, Complete Bridge Tx Hash test (ethereum#269) * deep copy value field, add tx hash test comment * typo * commitl1messages * lint * Revert "add L1 message sync service" This reverts commit 5305e8a. * Revert "move bridge client to separate file" This reverts commit 0b220be. * update branch * use commitMessages for l1Txs * little fix * fix config * fix test * comment fixes * fix * fix config check --------- Co-authored-by: Max Wolff <[email protected]> Co-authored-by: Max Wolff <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: Haichen Shen <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> * Add ErrUnknownAncestor tests (ethereum#305) add ErrUnknownAncestor tests * worker test include l1 msgs (ethereum#306) * worker test include l1 msgs * move L1 message index update next to block insertion --------- Co-authored-by: Péter Garamvölgyi <[email protected]> * exclude l1 messages from transaction count limit in block (ethereum#307) * exclude l1 messages from transaction count limit in block * fix comments * trigger ci * nit --------- Co-authored-by: Péter Garamvölgyi <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> * Expose queueIndex on Transaction (ethereum#316) expose queueIndex on Transaction * test that l1msg doesn't count in maxTxPerBlock limit (ethereum#312) * test that l1msg doesn't count in maxTxPerBlock limit * fix, comment * retrigger ci * change order inside test --------- Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: Péter Garamvölgyi <[email protected]> * reuse trace nonce field for queueIndex * expose scroll APIs on the geth console * add L1 message query APIs * Trigger new block on new l1 messages (ethereum#343) * trigger new block on new l1 messages * typo * initialize l1MsgCh * fix worker l1msg tests (ethereum#345) --------- Co-authored-by: Nazarii Denha <[email protected]> * test(worker): ensure that l1 messages are included in the correct order (ethereum#346) test that l1msgs added in correct order * rename enqueueIndex --> queueIndex * move QueueIndex into transaction * improve l1 db interface * formatting * bump version * print l1config * add API to query latest included message queue index * clean up tx limit logic * add clarifying comments and todos to ValidateL1Messages * improve db comments and logs * clean up L1MessageTx type handling * format * format * improve L1 message block check * fix missing L1 event handling * fix TestL1MessageValidationFailure * simplify sync height resume logic * make l1Config.l1MessageQueueAddress non-pointer * improve command line flags * remove todo * use abigen tools for log filtering * cache block L1 message count * nit: fix variable name case * improve logs * flush pending writes to DB before shutdown --------- Co-authored-by: Nazarii Denha <[email protected]> Co-authored-by: Max Wolff <[email protected]> Co-authored-by: Haichen Shen <[email protected]> Co-authored-by: Max Wolff <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]> Co-authored-by: HAOYUatHZ <[email protected]>

…error Fix error handling of batch pushResponse

…um#259)

* enhance 3 regions deployment * remove other regions config * remove other unused code

Gustav Simonsson added 3 commits January 15, 2015 19:40

Add new key_store interface and two new key stores

945798f

* Add new generic key_store interface * Add new plaintext key store storing unprotected keys on disk * Add new encrypted key store storing encrypted keys on disk * Add new entropy mixing function using OS and go runtime sources

Address pull request comments

47d3b3d

* Remove flags field from key struct * Change JSON struct fields from string to []byte * Change GenerateNewKey API to take io.Reader for random source * Remove mixing entropy source function * Use testing Fatal in tests

Gustav-Simonsson mentioned this pull request Jan 15, 2015

Add new key_store interface and two new key stores #243

Closed

Update code comments

9caf32b

obscuren reviewed Jan 19, 2015
View reviewed changes

obscuren mentioned this pull request Jan 19, 2015

KeyManager.KeyRing(): KeyPair => KeyRing #258

Closed

obscuren changed the title ~~Second PR for new key stores and interface~~ KeyStore (Low level key functional) Jan 19, 2015

obscuren changed the title ~~KeyStore (Low level key functional)~~ KeyStore (Low level key functionality) Jan 19, 2015

ebuchman reviewed Jan 19, 2015
View reviewed changes

Address pull request comments

3cf038f

* Allocate with composite literal instead of new * Remove check of number of bytes read from rand

fjl reviewed Jan 19, 2015
View reviewed changes

Address pull request comments

d48140c

* Further simplify "constructor" function's allocation of structs * Fix formatting

obscuren added a commit that referenced this pull request Jan 20, 2015

Merge pull request #259 from Gustav-Simonsson/develop

12fad65

KeyStore (Low level key functionality)

obscuren merged commit 12fad65 into ethereum:develop Jan 20, 2015

ngtuna pushed a commit to ngtuna/tomochain that referenced this pull request Nov 10, 2018

Merge pull request ethereum#259 from nguyenbatam/remove_useless_code

252ae51

remove useless code

maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Aug 13, 2021

rollup: remove dead serialization logic (ethereum#259)

1d2264b

* rollup: remove dead serialization logic * test: delete old test

sduchesneau pushed a commit to streamingfast/go-ethereum that referenced this pull request Jan 4, 2024

Merge pull request ethereum#259 from OffchainLabs/fix-batch-response-…

921163a

…error Fix error handling of batch pushResponse

luanxu-mxc pushed a commit to MXCzkEVM/mxc-geth that referenced this pull request Sep 2, 2024

feat(txpool): update max fee check in ValidateTransaction() (ethere…

ef40d46

…um#259)

s1na pushed a commit to s1na/go-ethereum that referenced this pull request Dec 2, 2024

enhance 3 regions deployment (ethereum#259)

5b75d3a

* enhance 3 regions deployment * remove other regions config * remove other unused code

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KeyStore (Low level key functionality) #259

KeyStore (Low level key functionality) #259

Gustav-Simonsson commented Jan 15, 2015

obscuren Jan 19, 2015

ebuchman Jan 19, 2015

Gustav-Simonsson Jan 19, 2015

fjl Jan 19, 2015

KeyStore (Low level key functionality) #259

KeyStore (Low level key functionality) #259

Conversation

Gustav-Simonsson commented Jan 15, 2015

obscuren Jan 19, 2015

Choose a reason for hiding this comment

ebuchman Jan 19, 2015

Choose a reason for hiding this comment

Gustav-Simonsson Jan 19, 2015

Choose a reason for hiding this comment

fjl Jan 19, 2015

Choose a reason for hiding this comment