Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tuple lengths; update list typedef format #723

Merged
merged 8 commits into from
Mar 6, 2019
Merged

Conversation

dankrad
Copy link
Contributor

@dankrad dankrad commented Mar 6, 2019

Adding tuple lengths in BeaconState object (this changes merkleization/serialization as no length mixin required)

djrtwo and others added 4 commits February 8, 2019 16:41
Weekly release of dev into master
Weekly release dev into master
Weekly release of dev into master
Adding tuple lengths in BeaconState objects (this changes merkleization/serialization as no length mixin required)
@djrtwo
Copy link
Contributor

djrtwo commented Mar 6, 2019

This is the format that we recently discussed, but note that it is not the format currently found in the SSZ spec. Need to decide one way or another and unify in this PR.

I lean toward this format for easy parsing.

@djrtwo djrtwo changed the title Add tuple lengths Add tuple lengths; update list typedef format Mar 6, 2019
@djrtwo
Copy link
Contributor

djrtwo commented Mar 6, 2019

Shall we make Deposit.proof of fixed size length as well? It is a known length of DEPOSIT_CONTRACT_TREE_DEPTH

@dankrad
Copy link
Contributor Author

dankrad commented Mar 6, 2019

Sounds very reasonable :) Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants