Weekly release of dev into master #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an implicit assert in `int_to_bytes4`, however I think it's rather hidden.
Ensures it does not try to shuffle out of range of the `active_validator_indices` list.
docs: fix typo in 0_beacon-chain.md
If this is accepted, then we can replace all uses of signing in the protocol, which are currently done in a relatively inconsistent way (see proposer signatures, attester signatures, shard proposer signatures, exit message signatures.....) could be unified.
This function is used to get the merkle root of some block roots which are themselves hashes, so the leaves do not need to be rehashed. Unfortunately, it's easy to assume that a merkle_root function would hash its leaves, so it should be clarified.
Refactor signature handling
Add explicit assert to get_permutated_index
Fix out-of-bounds in `get_shuffling`
* Updated phase 1: branch challenges * Removed unnecessary line * Added early subkey reveal slashing * Revealing during the active period is still revealing early * Added.... * Machinery for publishing old subkeys * Inability to withdraw until you published all subkeys * After a validator exits the queue there's still a minimum 1-day delay before they can withdraw (in the future this delay will be used as an opportunity to start a PoC challenge game) * Update 1_shard-data-chains.md * formatting * minor edits * Added masking scheme for reveals Secure under the aggregate extraction infeasibility assumption described on pages 11-12 of https://crypto.stanford.edu/~dabo/pubs/papers/aggreg.pdf * Added rewards going to challengers * Add ToC and reorg the constant tables * Remove tags * fix constant formatting * normalize domain constants in phase 1 * Update 1_shard-data-chains.md * Update 1_shard-data-chains.md * Update 1_shard-data-chains.md * Added transition logic * Fix ToC * Fix ToC * Adjusted for #615 * Added more helpers * epoch -> slot * fix some type hints * clean up `get_attestation_merkle_depth`
* updated SSZ implementation list Signed-off-by: sigmoid <[email protected]> * Update specs/simple-serialize.md Co-Authored-By: NAKsir-melody <[email protected]>
Fix typo from earlier renaming in #534.
Cuts validator record size from 120 to 106 bytes, and arguably is a simplification
Update is_power_of_two to not use log2
Co-Authored-By: djrtwo <[email protected]>
Turned slashed and initiated_exit into booleans
validator guide bug fixes
* Fix slot range for attestation inclusion * Update specs/core/0_beacon-chain.md Co-Authored-By: djrtwo <[email protected]>
Rename shard_block_root -> crosslink_data_root
See item 6 in #675. This makes transfers more generic.
make getting assignments more generic
Specify lexicographic ordering of crosslink_data_root
hwwhww
approved these changes
Feb 25, 2019
|
This still has the botched "[TODO: add logic to ensure that deposits from 1.0 chain are processed in order]" |
Allow transfers from non-activated validators
|
Made a separate PR for removing the todo @JustinDrake |
remove deposit order todo
JustinDrake
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed changelog coming in release notes.