-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
name changes #534
name changes #534
Conversation
@NIC619 This PR is making a minor change to the deposit contract. |
I saw @djrtwo changed I'm inclined to second #419, |
cc: @vbuterin regarding "operations -> transactions". I know many months ago you wanted to reserve the term "transaction" for user level. What are your thoughts on this now? |
Substrates calls the beacon operations/transactions "extrinsics". See https://www.youtube.com/watch?v=GDvV-Vn2u3w&t=928 Edit: False alert. They do call them "transactions" 😂 https://youtu.be/GDvV-Vn2u3w?t=1022 |
FYI: we are not renaming operations to transactions in Prysm. We generally think this should be reserved for user level and operations is the more intuitive name. We are also not renaming chainstart to eth2genesis. For the same reasons: more intuitive with the previous name. |
Fix typo from earlier renaming in #534.
ChainStart
->Eth2Genesis
Number
from custom typesSEED_LOOKAHEAD
->MIN_SEED_LOOKAHED
ENTRY_EXIT_DELAY
->ACTIVATION_EXIT_DELAY
INCLUDER_REWARD_QUOTIENT
->ATTESTATION_INCLUSION_REWARD_QUOTIENT
latest_index_roots
->latest_active_index_roots
current_epoch_start_shard
->current_shuffling_start_shard
,current_shuffling_epoch
,current_shuffling_seed
MIN_VALIDATOR_WITHDRAWAL_EPOCHS
->MIN_VALIDATOR_WITHDRAWAL_DELAY
MAX_WITHDRAWALS_PER_EPOCH
->MAX_EXIT_DEQUEUES_PER_EPOCH
ETH1_DATA_VOTING_PERIOD
->EPOCHS_PER_ETH1_VOTING_PERIOD
SLOT_DURATION
->SECONDS_PER_SLOT
EPOCH_LENGTH
->SLOTS_PER_EPOCH
Exits/penalties clean-up recap