Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name changes #534

Merged
merged 16 commits into from
Feb 14, 2019
Merged

name changes #534

merged 16 commits into from
Feb 14, 2019

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jan 31, 2019

  • penalized -> slashed
  • exit -> voluntary exit
  • operations -> transactions
  • initial, startup -> genesis
  • ChainStart -> Eth2Genesis
  • Remove Number from custom types
  • SEED_LOOKAHEAD -> MIN_SEED_LOOKAHED
  • ENTRY_EXIT_DELAY -> ACTIVATION_EXIT_DELAY
  • INCLUDER_REWARD_QUOTIENT -> ATTESTATION_INCLUSION_REWARD_QUOTIENT
  • latest_index_roots -> latest_active_index_roots
  • current_epoch_start_shard -> current_shuffling_start_shard, current_shuffling_epoch, current_shuffling_seed
  • MIN_VALIDATOR_WITHDRAWAL_EPOCHS -> MIN_VALIDATOR_WITHDRAWAL_DELAY
  • MAX_WITHDRAWALS_PER_EPOCH -> MAX_EXIT_DEQUEUES_PER_EPOCH
  • ETH1_DATA_VOTING_PERIOD -> EPOCHS_PER_ETH1_VOTING_PERIOD
  • SLOT_DURATION -> SECONDS_PER_SLOT
  • EPOCH_LENGTH -> SLOTS_PER_EPOCH

Exits/penalties clean-up recap

  • exits
    • voluntary exits
    • forceful exits
      • slashings
      • ejections
  • penalties
    • base penalties
    • inactivity penalties
    • (partial) slashings

@djrtwo djrtwo changed the base branch from master to dev January 31, 2019 15:49
@djrtwo
Copy link
Contributor Author

djrtwo commented Jan 31, 2019

@NIC619 This PR is making a minor change to the deposit contract. ChainStart -> Eth2Genesis

@hwwhww
Copy link
Contributor

hwwhww commented Feb 1, 2019

I saw @djrtwo changed BLS pubkey/signature -> BLS 12-381 pubkey/signature, and also found @JustinDrake changed proof of possession (a BLS signature) to proof of possession (a BLS12 signature).

I'm inclined to second #419, BLS pubkey/signature sounds more neutral and future-proof to me as these pubkeys and signatures (with BLS12-381 curve) should be fit in the BLS signature scheme, or anything I missed?

@JustinDrake JustinDrake mentioned this pull request Feb 12, 2019
29 tasks
@djrtwo
Copy link
Contributor Author

djrtwo commented Feb 12, 2019

cc: @vbuterin regarding "operations -> transactions". I know many months ago you wanted to reserve the term "transaction" for user level. What are your thoughts on this now?

@JustinDrake
Copy link
Collaborator

😂

screenshot 2019-02-12 at 19 48 39

@JustinDrake
Copy link
Collaborator

JustinDrake commented Feb 13, 2019

Substrates calls the beacon operations/transactions "extrinsics". See https://www.youtube.com/watch?v=GDvV-Vn2u3w&t=928

Edit: False alert. They do call them "transactions" 😂 https://youtu.be/GDvV-Vn2u3w?t=1022

@prestonvanloon
Copy link
Contributor

FYI: we are not renaming operations to transactions in Prysm. We generally think this should be reserved for user level and operations is the more intuitive name.

We are also not renaming chainstart to eth2genesis. For the same reasons: more intuitive with the previous name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants