Add mandatory deposit index ordering #594
Conversation
Co-requisite with #589
specs/core/0_beacon-chain.md
Outdated
| @@ -1478,6 +1479,7 @@ def get_initial_beacon_state(initial_validator_deposits: List[Deposit], | |||
| # Ethereum 1.0 chain data | |||
| latest_eth1_data=latest_eth1_data, | |||
| eth1_data_votes=[], | |||
| deposit_index=0 | |||
There was a problem hiding this comment.
This should default to len(initial_validator_deposits)
There was a problem hiding this comment.
Done. Though note that all this introduces one issue: if there are bad deposits before launch, then there will be a bunch of deposits that have to be reprocessed before any new deposits can be processed. I guess it's fine because they'll all fail due to the pubkey uniqueness check?
There was a problem hiding this comment.
I don't think so. This will ensure that we don't have to attempt to process any failed deposits -- thus starting from the next deposit after the initial.
I'm assuming that initial_validator_deposits includes invalid ones that will just get skipped over in process_deposit below
There was a problem hiding this comment.
Aah I see, if initial_validator_deposits includes invalid ones then there's no issue.
* Rename 1. `get_initial_beacon_state` -> `get_genesis_beacon_state` 2. `initial_validator_deposits` -> `genesis_validator_deposits` * Add BeaconState.deposit_index (ethereum/consensus-specs#594) * Use BLS-based RANDAO types and modify `process_deposit` * Remove outdated per-slot `proposer.randao_layers` and `state.latest_randao_mixes` update * Update eth2/beacon/types/blocks.py Co-Authored-By: hwwhww <[email protected]>
Co-requisite with #589