Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Invalid Deposits, Add Deposit Index Ordering - (Spec PR #589, #594) #404

Closed
schroedingerscode opened this issue Feb 27, 2019 · 2 comments
Labels
enhancement 🕵️‍♀️ New feature or request in progress 🚧 This issue or pull request is in progress

Comments

@schroedingerscode
Copy link
Contributor

Description

As an implementor, I want to add mandatory deposit index ordering so that block proposers may skip invalid blocks and Artemis is in sync with the Beacon Chain spec.

Acceptance Criteria

  • Ensure process_deposit logic does not fail the entire block when an invalid proof of possession is provided. (See PR 589 below.)
  • Add deposit_index to BeaconState.
  • Initialize deposit_index in get_initial_beacon_state.
  • Verify that deposit.index == state.deposit_index in processDeposits section of per-block processing.
  • Increment state.deposit_index after processing the deposit in deposits section of the per-block processing.

Additional Information

@vitorpy
Copy link
Contributor

vitorpy commented Mar 1, 2019

Working on this.

@schroedingerscode
Copy link
Contributor Author

Closed by #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🕵️‍♀️ New feature or request in progress 🚧 This issue or pull request is in progress
Projects
None yet
Development

No branches or pull requests

2 participants