-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove is_merge_transition_block
check since Capella
#3232
Conversation
Nice! +1 for client code clean up. But also worth checking if this breaks existing Hive or Antithesis tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm mixed on the proposal. we don't yet remove it from the state transition function so weird to remove it only in one place
I also could imagine some use for doing a transition at Capella on an alternative network.
That said, I'm not that opposed to this if others want it. Def want to check with @marioevz to see if this will break some hive assumption
Though, it would be still possible to do the merge transition at the same time as Deneb, I would consider doing a full clean up of transition logic at that time as introducing blob transactions on EL without execution enabled on CL is odd.
They would need to schedule Bellatrix first and then after the transition happens they could schedule Cancun. Also, those networks would need clients supporting transition logic. |
6cc5b0f
to
9efce2f
Compare
This is consistent with simply not ever supporting doing a merge again. That, in itself, I have no objection to: either start unmerged and stay unmerged, or start merged. However, if merging is supported at all (e.g., insofar as the Bellatrix fork retains such a function), this ensures that merging remains a strangely partly-supported functionality, if and only if one goes back to Bellatrix. I am not strongly against this, but it conveys a rather muddy conceptual model. |
9efce2f
to
340f3cc
Compare
is_merge_transition_block
check from Capellais_merge_transition_block
check since Capella
This PR removed the
is_merge_transition_block
check from Capellaon_block
:At least for mainnet, these checks are useless.
From @mkalinin: