Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync Committee vs Aggregate naming consistencies #2469

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Sync Committee vs Aggregate naming consistencies #2469

merged 3 commits into from
Jun 7, 2021

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Jun 7, 2021

Address all points brought up in #2433

@djrtwo djrtwo requested review from protolambda and hwwhww June 7, 2021 22:16
@djrtwo djrtwo force-pushed the sync-consistency branch from d000f62 to 09b6fb0 Compare June 7, 2021 22:17
@djrtwo
Copy link
Contributor Author

djrtwo commented Jun 7, 2021

fixing tests

protolambda
protolambda approved these changes Jun 7, 2021
View reviewed changes
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed one reference in the validator doc, can't find more, LGTM!

@protolambda protolambda merged commit c821e3f into dev Jun 7, 2021
@protolambda protolambda deleted the sync-consistency branch June 7, 2021 23:30
@protolambda protolambda mentioned this pull request Jun 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

@hwwhww hwwhww Awaiting requested review from hwwhww

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @protolambda