-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match gossip v1.1 D_low, extend gossip_history param, add FAQ section #1958
Conversation
I think we should define Considering dropping heartbeat_interval to 700ms as per the recommendation of the gossipsub v1.1 report (page 6) |
We've also conflated arguably I'm not sure the exact trade-off at play when increasing/decreasing Writing some quick notes on the intuition on If we increase If we increase both Also seems to make sense to have |
Re: This isn't breaking obviously but does result in spam; might be an argument to keep the ttl closer to 1-2 slots. |
Co-authored-by: Diederik Loerakker <[email protected]>
This PR updates the gossip sub parameters in the spec:
D_low
default recommend parameter which changed in v1.1gossip_history
tomcache_len
to match param names in specgossip_advertise
tomcache_gossip
to match param names in specseen_ttl
as seen in specheartbeat_interval
from 1s to 0.7s as per the recommendation of v1.1 PL report to allow for more responsiveness in the event that gossip is not performing optimallymcache_len
from5
to6
to allow for at least ~2s for IWANT queries after IHAVEs have been sent. This it to match original time window but to compensate or our fasterheartbeat_interval
seen_ttl
to550
to match the length of an epoch (contextualized byheartbeat_interval
)